Mir

Code review comment for lp:~nick-dedekind/mir/trusted_sessions

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

After fixing the (trivial) conflict in src/client/CMakeLists.txt there are test failures:

[ RUN ] SessionMediatorTest.client_socket_fd_calls_connector_client_socket_fd
unknown file: Failure
C++ exception with description "Invalid trust session" thrown in the test body.
/home/alan/display_server/development-branch/tests/unit-tests/frontend/test_session_mediator.cpp:733: Failure
Actual function call count doesn't match EXPECT_CALL(connector, client_socket_fd(_))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
[ FAILED ] SessionMediatorTest.client_socket_fd_calls_connector_client_socket_fd (0 ms)
[ RUN ] SessionMediatorTest.client_socket_fd_allocates_requested_number_of_fds
unknown file: Failure
C++ exception with description "Invalid trust session" thrown in the test body.
/home/alan/display_server/development-branch/tests/unit-tests/frontend/test_session_mediator.cpp:758: Failure
Actual function call count doesn't match EXPECT_CALL(connector, client_socket_fd(_))...
         Expected: to be called 11 times
           Actual: never called - unsatisfied and active
[ FAILED ] SessionMediatorTest.client_socket_fd_allocates_requested_number_of_fds (0 ms)

~~~~

[ RUN ] TrustSessionHelper.gets_fds_for_trusted_clients
/home/alan/display_server/development-branch/tests/acceptance-tests/test_trust_session_helper.cpp:90: Failure
Value of: actual_fd_count
Expected: is equal to 3
  Actual: 0 (of type unsigned long)
[ FAILED ] TrustSessionHelper.gets_fds_for_trusted_clients (12 ms)

review: Needs Fixing

« Back to merge proposal