Mir

Code review comment for lp:~nick-dedekind/mir/trusted_sessions

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

+class TrustSessionListener
+{
+public:
+ virtual void starting(std::shared_ptr<TrustSession> const& trust_session) = 0;
+ virtual void stopping(std::shared_ptr<TrustSession> const& trust_session) = 0;
+
+ virtual void trusted_session_beginning(TrustSession& trust_session, std::shared_ptr<Session> const& session) = 0;
+ virtual void trusted_session_ending(TrustSession& trust_session, std::shared_ptr<Session> const& session) = 0;

The listener shouldn't be given any ownership of the referenced objects. So the prototypes should be:

    virtual void starting(TrustSession const& trust_session) = 0;
    virtual void stopping(TrustSession const& trust_session) = 0;

    virtual void trusted_session_beginning(TrustSession& trust_session, Session const& session) = 0;
    virtual void trusted_session_ending(TrustSession& trust_session, Session const& session) = 0;

review: Needs Fixing

« Back to merge proposal