Mir

Code review comment for lp:~nick-dedekind/mir/trusted_sessions

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This isn't a full review, but some minor fixes to do in the mean time...

(1) Please follow the existing convention, which would mean:
396 +MirTrustSession* mir_trust_session_create(MirConnection* connection);
becomes:
MirTrustSession* mir_connection_create_trust_session(MirConnection* connection);

(2) Please put the details/justification you mentioned in the commit message or proposal description. A four word description for a 3713 line proposal is a bit brief...

review: Needs Fixing

« Back to merge proposal