Mir

Code review comment for lp:~nick-dedekind/mir/trusted_sessions

  1. trusted_sessions
  2. Merge into development-branch
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Wow, so much code. This will take a while...

(1) One quick note:
1196 +MirTrustedSession* mir_trusted_session_create(MirConnection* connection)
The pattern we use is "NAMESPACE_OBJECT_ACTION", so that should be:
    MirTrustedSession* mir_connection_create_trusted_session(MirConnection* connection)
Although since "session" was never an object in the client API before, the word "trusted" is superfluous and could be removed. Even if only from the public client API.

review: Needs Fixing

« Back to merge proposal