Code review comment for lp:~nicholas-dahm/igraph/compat-fn

Revision history for this message
Gábor Csárdi (gabor.csardi) wrote :

Three more comments.

1 I eliminated the struct for the extra arguments, it is just a void* now everywhere.
2 It is useful to write a test case for a new functionality, see #2762.
3 From the test case it turns out quickly, that the edge-compatibility functions were never called, I have fixed this.

Thanks again for your code!

« Back to merge proposal