Merge lp:~nextrevision/charms/precise/openvpn/trunk into lp:charms/openvpn

[John Patterson]

Correctly categorized charm as cache-proxy (a better fit IMHO compared to the previous category 'application', which was also misspelled) and updated config.yaml with defaults on all variables. Also removed the revision file, as it is no longer needed. This charm still does not provide anything with regards to interfaces, and that is still by design until someone comes up with a cool use in that case.

[Matt Bruzek (mbruzek)]

# Proof

There is only one outstanding issue when running charm proof:

$ juju charm proof openvpn
I: all charms should provide at least one thing

# Review

+1 review. The changes made in this proposal look good to me.

# Knitpick

None.

review: Approve (+1)

[Matt Bruzek (mbruzek)]

Hello John,

Thanks for the improvements to the openvpn charm. My review has not found any problems with this merge set but I am not yet a charmer so someone else will be along to review this soon.

The categorization looks correct now and the revision file is no longer needed. I did list the charm proof statement there just to be complete. As you mention in the description the charm does not provide anything and that is by design so I believe that proof message is OK.

Thanks for your work making the openvpn charm better!

[Marco Ceppi (marcoceppi)]

LGTM +1

review: Approve

=== modified file 'config.yaml'
--- config.yaml	2013-07-02 17:23:27 +0000
+++ config.yaml	2014-01-24 02:23:20 +0000
@@ -5,6 +5,7 @@
     description: user for certificate generation
   domain:
     type: string
+    default: ""
     description: FQDN of the server, defaults to unit's given hostname
   port:
     type: int
@@ -36,6 +37,7 @@
     description: network to use for client addressing; must include a cidr suffix, i.e. X.X.X.X/XX
   additional-routes:
     type: string
+    default: ""
     description: additional routes to be routed through the VPN (i.e. '1.1.1.0/23, 2.2.2.0/8')
   key-size:
     type: int
 
=== modified file 'metadata.yaml'
--- metadata.yaml	2013-08-31 16:50:38 +0000
+++ metadata.yaml	2014-01-24 02:23:20 +0000
@@ -11,5 +11,4 @@
   key exchange. It also supports VPNs with dynamic endpoints (DHCP or
   dial-up clients), tunnels over NAT or connection-oriented stateful
   firewalls (such as Linux's iptables).
-categories:
-  - application
+categories: ["cache-proxy"]
 
=== removed file 'revision'
--- revision	2013-08-31 16:50:38 +0000
+++ revision	1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
-5