Code review comment for lp:~newell-jensen/maas/rack_register_command

Maas-region createadmin --password your-clear-text-pass

On Tuesday, May 24, 2016, Gavin Panella <email address hidden> wrote:

> Review: Abstain
>
> The justifications given in the call yesterday for using a command-line
> argument over the mechanism used by install-shared-secret were:
>
> 1. It's easier to automate.
>
> 2. MAAS accepts passwords via the command-line elsewhere.
>
> #1 is incorrect. #2 says that it's broken elsewhere so we'll break it
> here for the sake of #1. The example of install-shared-secret means that
> #2 can also be used to argue exactly the opposite, i.e.:
>
> 2b. MAAS does not accept passwords via the command-line elsewhere.
>
> Newell, this is nothing personal — you've implemented what was requested
> — but I can't approve this and remain honest.
>
> --
>
> https://code.launchpad.net/~newell-jensen/maas/rack_register_command/+merge/295101
> You are subscribed to branch lp:maas.
>

--
Andres Rodriguez (RoAkSoAx)
Ubuntu Server Developer
MSc. Telecom & Networking
Systems Engineer