Merge ~newell-jensen/maas:lp1823265 into maas:master

[Newell Jensen]

LP: #1823265 -- validate hostname for pod composition with ValidationService.validateHostname to be consistent with other areas of MAAS.

[Andres Rodriguez (andreserl)]

lgtm! however, thsi doesn't really address the issue because if someone creates a machine via the API with a hostname with an '_', it will also result it it being allowed by the api, but failure later.

review: Approve

diff --git a/src/maasserver/static/js/angular/controllers/pod_details.js b/src/maasserver/static/js/angular/controllers/pod_details.js
index 8a32b8e..938bc67 100644
--- a/src/maasserver/static/js/angular/controllers/pod_details.js
+++ b/src/maasserver/static/js/angular/controllers/pod_details.js
@@ -1,4 +1,4 @@
-/* Copyright 2017-2018 Canonical Ltd.  This software is licensed under the
+/* Copyright 2017-2019 Canonical Ltd.  This software is licensed under the
  * GNU Affero General Public License version 3 (see the file LICENSE).
  *
  * MAAS Pod Details Controller
@@ -256,9 +256,7 @@ function PodDetailsController(
 
     var hostname = $scope.compose.obj.hostname;
 
-    if (hostname && hostname.includes("_")) {
-      return false;
-    }
+    valid = ValidationService.validateHostname(hostname);
 
     requests.forEach(function(request) {
       if (request.size > request.available || request.size === "") {
diff --git a/src/maasserver/static/js/angular/controllers/tests/test_pod_details.js b/src/maasserver/static/js/angular/controllers/tests/test_pod_details.js
index 5b053f0..db4e781 100644
--- a/src/maasserver/static/js/angular/controllers/tests/test_pod_details.js
+++ b/src/maasserver/static/js/angular/controllers/tests/test_pod_details.js
@@ -1,4 +1,4 @@
-/* Copyright 2017-2018 Canonical Ltd.  This software is licensed under the
+/* Copyright 2017-2019 Canonical Ltd.  This software is licensed under the
  * GNU Affero General Public License version 3 (see the file LICENSE).
  *
  * Unit tests for PodDetailsController.
@@ -560,6 +560,20 @@ describe("PodDetailsController", function() {
     });
   });
 
+  describe("validateMachineCompose", function() {
+    it("returns true for valid hostname", function() {
+      makeController();
+      $scope.compose.obj.hostname = "testing-hostname";
+      expect($scope.validateMachineCompose()).toBe(true);
+    });
+
+    it("returns false for invalid hostname", function() {
+      makeController();
+      $scope.compose.obj.hostname = "testing_hostname";
+      expect($scope.validateMachineCompose()).toBe(false);
+    });
+  });
+
   describe("totalStoragePercentage", function() {
     it("returns the correct percentage", function() {
       makeController();