MAAS

Merge ~newell-jensen/maas:lp1812360 into maas:master

  1. Git
  2. lp:~newell-jensen/maas
  3. lp1812360
  4. Merge into master
Proposed by Newell Jensen
Status: Merged
Approved by: Newell Jensen
Approved revision: 99eb4d564d1cd03521fae7ea0ee4d42c680825da
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~newell-jensen/maas:lp1812360
Merge into: maas:master
Diff against target: 12 lines (+1/-0)
1 file modified
src/provisioningserver/drivers/pod/virsh.py (+1/-0)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+365493@code.launchpad.net

Commit message

LP: #1812360 -- Enable console logging for s390x.

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm! but this needs testing before landing as I'm not risking another breakage of KVM host support for s390x

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/provisioningserver/drivers/pod/virsh.py b/src/provisioningserver/drivers/pod/virsh.py
2index 0dbb44f..fee4ec3 100644
3--- a/src/provisioningserver/drivers/pod/virsh.py
4+++ b/src/provisioningserver/drivers/pod/virsh.py
5@@ -224,6 +224,7 @@ DOM_TEMPLATE_S390X = dedent("""
6 </features>
7 <devices>
8 <console type='pty'>
9+ <log file='/var/log/libvirt/qemu/{name}-serial0.log' append='off'/>
10 <target type='sclp' port='0'/>
11 <alias name='console0'/>
12 </console>

Subscribers

People subscribed via source and target branches