Code review comment for ~newell-jensen/maas:lp1812509

Revision history for this message
Newell Jensen (newell-jensen) wrote :

> I need more context before I can review this. Which revision and migration
> caused this bug to happen?
>
> I'd like to look more into this, since the solution looks more like a
> workaround than a proper fix.

Before the migration, machines with a manual power type were all linked to a singleton BMC. The migration broke up this linked BMC and made it so all the machines had their own BMC. This causes an exception to be raised at this particular point in the code. If we introduced another migration to fix this issue, we would have to rearrange previous migrations, as this needs to be backported to 2.5. I agree with your comment on the XXX portion.

« Back to merge proposal