Merge ~newell-jensen/maas:redfish-power-driver into maas:master

[Newell Jensen]

Refactor out redfish common code from the Intel RSD Pod driver to RedfishPowerDriver and have RSDPodDriver inherit from this class.

This branch factors out the redfish logic from the Intel RSD Pod driver and put this in its own RedfishPowerDriver class that RSDPodDriver now inherits from. This branch does not add SSL verification support, which will be done in a follow up branch.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b redfish-power-driver lp:~newell-jensen/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 3e24f9989a015b72e01317699a589b15d87f7b6e

review: Approve

[Mike Pontillo (mpontillo)]

This change looks straightforward despite its large size. Let's hold off approving this branch until 2.5.1 opens, as Andres reminded us this morning.

I have a minor comment regarding a comment below.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b redfish-power-driver lp:~newell-jensen/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/4681/console
COMMIT: 28214014ad692c6612e41f345b356eed42dfbf3b

review: Needs Fixing

[MAAS Lander (maas-lander)]

UNIT TESTS
-b redfish-power-driver lp:~newell-jensen/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: a7ee1527a9fe9c0e900d66eb39e42a5fb52d7122

review: Approve

[Mike Pontillo (mpontillo)]

Looks good to me; nice job!

I understand we will address https certificate verification issues in a subsequent commit; I think that's fine.

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b redfish-power-driver lp:~newell-jensen/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/4723/consoleText

diff --git a/src/provisioningserver/drivers/pod/rsd.py b/src/provisioningserver/drivers/pod/rsd.py
index 97c1764..8230a12 100644
--- a/src/provisioningserver/drivers/pod/rsd.py
+++ b/src/provisioningserver/drivers/pod/rsd.py
@@ -1,4 +1,4 @@
-# Copyright 2017 Canonical Ltd.  This software is licensed under the
+# Copyright 2017-2018 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Rack Scale Design pod driver."""
@@ -7,7 +7,6 @@ __all__ = [
     'RSDPodDriver',
     ]
 
-from base64 import b64encode
 from http import HTTPStatus
 from io import BytesIO
 import json
@@ -27,9 +26,13 @@ from provisioningserver.drivers.pod import (
     DiscoveredPod,
     DiscoveredPodHints,
     PodActionError,
-    PodDriver,
+    PodDriverBase,
     PodFatalError,
 )
+from provisioningserver.drivers.power.redfish import (
+    RedfishPowerDriverBase,
+    WebClientContextFactory,
+)
 from provisioningserver.logger import get_maas_logger
 from provisioningserver.rpc.exceptions import PodInvalidResources
 from provisioningserver.utils.twisted import (
@@ -37,23 +40,19 @@ from provisioningserver.utils.twisted import (
     pause,
 )
 from twisted.internet import reactor
-from twisted.internet._sslverify import (
-    ClientTLSOptions,
-    OpenSSLCertificateOptions,
-)
 from twisted.internet.defer import inlineCallbacks
 from twisted.web.client import (
     Agent,
-    BrowserLikePolicyForHTTPS,
     FileBodyProducer,
     PartialDownloadError,
     readBody,
 )
-from twisted.web.http_headers import Headers
 
 
 maaslog = get_maas_logger("drivers.pod.rsd")
 
+RSD_POWER_CONTROL_ENDPOINT = b"redfish/v1/Nodes/%s/Actions/ComposedNode.Reset"
+
 # RSD stores the architecture with a different
 # label then MAAS. This maps RSD architecture to
 # MAAS architecture.
@@ -76,19 +75,12 @@ RSD_NODE_POWER_STATE = {
     }
 
 
-class WebClientContextFactory(BrowserLikePolicyForHTTPS):
-
-    def creatorForNetloc(self, hostname, port):
-        opts = ClientTLSOptions(
-            hostname.decode("ascii"),
-            OpenSSLCertificateOptions(verify=False).getContext())
-        # This forces Twisted to not validate the hostname of the certificate.
-        opts._ctx.set_info_callback(lambda *args: None)
-        return opts
-
+class RSDPodDriver(RedfishPowerDriverBase, PodDriverBase):
 
-class RSDPodDriver(PodDriver):
+    chassis = True  # Pods are always a chassis
 
+    # RSDPodDriver inherits from RedfishPowerDriver.
+    # Power parameters will need to be changed to reflect this.
     name = 'rsd'
     description = "Rack Scale Design"
     settings = [
@@ -108,26 +100,6 @@ class RSDPodDriver(PodDriver):
         # no required packages
         return []
 
-    def get_url(self, context):
-        """Return url for the pod."""
-        url = context.get('power_address')
-        if "https" not in url and "http" not in url:
-            # Prepend https
-            url = join("https://", url)
-        return url.encode('utf-8')
-
-    def make_auth_headers(self, power_user, power_pass, **kwargs):
-        """Return authentication headers."""
-        creds = "%s:%s" % (power_user, power_pass)
-        authorization = b64encode(creds.encode('utf-8'))
-        return Headers(
-            {
-                b"User-Agent": [b"MAAS"],
-                b"Authorization": [b"Basic " + authorization],
-                b"Content-Type": [b"application/json; charset=utf-8"],
-            }
-        )
-
     @asynchronous
     def redfish_request(self, method, uri, headers=None, bodyProducer=None):
         """Send the redfish request and return the response."""
@@ -140,7 +112,7 @@ class RSDPodDriver(PodDriver):
 
             def eb_catch_partial(failure):
                 # Twisted is raising PartialDownloadError because the responses
-                # do not contains a Content-Length header. Since every response
+                # do not contain a Content-Length header. Since every response
                 # holds the whole body we just take the result.
                 failure.trap(PartialDownloadError)
                 if int(failure.value.status) == HTTPStatus.OK:
@@ -150,7 +122,7 @@ class RSDPodDriver(PodDriver):
 
             def cb_json_decode(data):
                 data = data.decode('utf-8')
-                # Only decode non-empty responses.
+                # Only decode non-empty response bodies.
                 if data:
                     response = json.loads(data)
                     if "error" in response:
@@ -1084,22 +1056,6 @@ class RSDPodDriver(PodDriver):
         return discovered_pod.hints
 
     @inlineCallbacks
-    def set_pxe_boot(self, url, node_id, headers):
-        """Set the composed machine with node_id to PXE boot."""
-        endpoint = b"redfish/v1/Nodes/%s" % node_id
-        payload = FileBodyProducer(
-            BytesIO(
-                json.dumps(
-                    {
-                        'Boot': {
-                            'BootSourceOverrideEnabled': "Once",
-                            'BootSourceOverrideTarget': "Pxe"
-                        }
-                    }).encode('utf-8')))
-        yield self.redfish_request(
-            b"PATCH", join(url, endpoint), headers, payload)
-
-    @inlineCallbacks
     def get_composed_node_state(self, url, node_id, headers):
         """Return the `ComposedNodeState` of the composed machine."""
         endpoint = b"redfish/v1/Nodes/%s" % node_id
@@ -1149,8 +1105,24 @@ class RSDPodDriver(PodDriver):
                 " of Failed." % node_id)
 
     @inlineCallbacks
+    def set_pxe_boot(self, url, node_id, headers):
+        """Set the composed machine with node_id to PXE boot."""
+        endpoint = b"redfish/v1/Nodes/%s" % node_id
+        payload = FileBodyProducer(
+            BytesIO(
+                json.dumps(
+                    {
+                        'Boot': {
+                            'BootSourceOverrideEnabled': "Once",
+                            'BootSourceOverrideTarget': "Pxe"
+                        }
+                    }).encode('utf-8')))
+        yield self.redfish_request(
+            b"PATCH", join(url, endpoint), headers, payload)
+
+    @inlineCallbacks
     def power(self, power_change, url, node_id, headers):
-        endpoint = b"redfish/v1/Nodes/%s/Actions/ComposedNode.Reset" % node_id
+        endpoint = RSD_POWER_CONTROL_ENDPOINT % node_id
         payload = FileBodyProducer(
             BytesIO(
                 json.dumps(
diff --git a/src/provisioningserver/drivers/pod/tests/test_rsd.py b/src/provisioningserver/drivers/pod/tests/test_rsd.py
index b3464c5..b4cc83c 100644
--- a/src/provisioningserver/drivers/pod/tests/test_rsd.py
+++ b/src/provisioningserver/drivers/pod/tests/test_rsd.py
@@ -1,21 +1,17 @@
-# Copyright 2017 Canonical Ltd.  This software is licensed under the
+# Copyright 2017-2018 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Tests for `provisioningserver.drivers.pod.rsd`."""
 
 __all__ = []
 
-from base64 import b64encode
 from copy import deepcopy
 from http import HTTPStatus
 from io import BytesIO
 import json
 from os.path import join
 import random
-from unittest.mock import (
-    call,
-    Mock,
-)
+from unittest.mock import call
 
 from maastesting.factory import factory
 from maastesting.matchers import (
@@ -45,7 +41,6 @@ from provisioningserver.drivers.pod.rsd import (
     RSD_NODE_POWER_STATE,
     RSD_SYSTEM_POWER_STATE,
     RSDPodDriver,
-    WebClientContextFactory,
 )
 import provisioningserver.drivers.pod.rsd as rsd_module
 from provisioningserver.rpc.exceptions import PodInvalidResources
@@ -57,12 +52,7 @@ from testtools.matchers import (
     MatchesListwise,
     MatchesStructure,
 )
-from twisted.internet._sslverify import ClientTLSOptions
-from twisted.internet.defer import (
-    fail,
-    inlineCallbacks,
-    succeed,
-)
+from twisted.internet.defer import inlineCallbacks
 from twisted.web.client import (
     FileBodyProducer,
     PartialDownloadError,
@@ -790,16 +780,6 @@ def make_discovered_pod(
     return discovered_pod
 
 
-class TestWebClientContextFactory(MAASTestCase):
-
-    def test_creatorForNetloc_returns_tls_options(self):
-        hostname = factory.make_name('hostname').encode('utf-8')
-        port = random.randint(1000, 2000)
-        contextFactory = WebClientContextFactory()
-        opts = contextFactory.creatorForNetloc(hostname, port)
-        self.assertIsInstance(opts, ClientTLSOptions)
-
-
 class TestRSDPodDriver(MAASTestCase):
 
     run_tests_with = MAASTwistedRunTest.make_factory(timeout=5)
@@ -810,116 +790,6 @@ class TestRSDPodDriver(MAASTestCase):
         missing = driver.detect_missing_packages()
         self.assertItemsEqual([], missing)
 
-    def test_get_url_with_ip(self):
-        driver = RSDPodDriver()
-        context = make_context()
-        ip = context.get('power_address').encode('utf-8')
-        expected_url = b"https://%s" % ip
-        url = driver.get_url(context)
-        self.assertEqual(expected_url, url)
-
-    def test_get_url_with_https(self):
-        driver = RSDPodDriver()
-        context = make_context()
-        context['power_address'] = join(
-            "https://", context['power_address'])
-        expected_url = context.get('power_address').encode('utf-8')
-        url = driver.get_url(context)
-        self.assertEqual(expected_url, url)
-
-    def test_get_url_with_http(self):
-        driver = RSDPodDriver()
-        context = make_context()
-        context['power_address'] = join(
-            "http://", context['power_address'])
-        expected_url = context.get('power_address').encode('utf-8')
-        url = driver.get_url(context)
-        self.assertEqual(expected_url, url)
-
-    def test__make_auth_headers(self):
-        power_user = factory.make_name('power_user')
-        power_pass = factory.make_name('power_pass')
-        creds = "%s:%s" % (power_user, power_pass)
-        authorization = b64encode(creds.encode('utf-8'))
-        attributes = {
-            b"User-Agent": [b"MAAS"],
-            b"Authorization": [b"Basic " + authorization],
-            b"Content-Type": [b"application/json; charset=utf-8"],
-        }
-        driver = RSDPodDriver()
-        headers = driver.make_auth_headers(power_user, power_pass)
-        self.assertEquals(headers, Headers(attributes))
-
-    @inlineCallbacks
-    def test_redfish_request_renders_response(self):
-        driver = RSDPodDriver()
-        context = make_context()
-        url = driver.get_url(context)
-        uri = join(url, b"redfish/v1/Systems")
-        headers = driver.make_auth_headers(**context)
-        mock_agent = self.patch(rsd_module, 'Agent')
-        mock_agent.return_value.request = Mock()
-        expected_headers = Mock()
-        expected_headers.headers = "Testing Headers"
-        mock_agent.return_value.request.return_value = succeed(
-            expected_headers)
-        mock_readBody = self.patch(rsd_module, 'readBody')
-        mock_readBody.return_value = succeed(
-            json.dumps(SAMPLE_JSON_SYSTEMS).encode('utf-8'))
-        expected_response = SAMPLE_JSON_SYSTEMS
-
-        response, headers = yield driver.redfish_request(b"GET", uri, headers)
-        self.assertEquals(expected_response, response)
-        self.assertEquals(expected_headers.headers, headers)
-
-    @inlineCallbacks
-    def test_redfish_request_continues_partial_download_error(self):
-        driver = RSDPodDriver()
-        context = make_context()
-        url = driver.get_url(context)
-        uri = join(url, b"redfish/v1/Systems")
-        headers = driver.make_auth_headers(**context)
-        mock_agent = self.patch(rsd_module, 'Agent')
-        mock_agent.return_value.request = Mock()
-        expected_headers = Mock()
-        expected_headers.headers = "Testing Headers"
-        mock_agent.return_value.request.return_value = succeed(
-            expected_headers)
-        mock_readBody = self.patch(rsd_module, 'readBody')
-        error = PartialDownloadError(
-            response=json.dumps(SAMPLE_JSON_SYSTEMS).encode('utf-8'),
-            code=HTTPStatus.OK)
-        mock_readBody.return_value = fail(error)
-        expected_response = SAMPLE_JSON_SYSTEMS
-
-        response, headers = yield driver.redfish_request(b"GET", uri, headers)
-        self.assertEquals(expected_response, response)
-        self.assertEquals(expected_headers.headers, headers)
-
-    @inlineCallbacks
-    def test_redfish_request_raises_failures(self):
-        driver = RSDPodDriver()
-        context = make_context()
-        url = driver.get_url(context)
-        uri = join(url, b"redfish/v1/Systems")
-        headers = driver.make_auth_headers(**context)
-        mock_agent = self.patch(rsd_module, 'Agent')
-        mock_agent.return_value.request = Mock()
-        expected_headers = Mock()
-        expected_headers.headers = "Testing Headers"
-        mock_agent.return_value.request.return_value = succeed(
-            expected_headers)
-        mock_readBody = self.patch(rsd_module, 'readBody')
-        error = PartialDownloadError(
-            response=json.dumps(SAMPLE_JSON_SYSTEMS).encode('utf-8'),
-            code=HTTPStatus.NOT_FOUND)
-        mock_readBody.return_value = fail(error)
-
-        with ExpectedException(PartialDownloadError):
-            yield driver.redfish_request(b"GET", uri, headers)
-        self.assertThat(mock_readBody, MockCalledOnceWith(
-            expected_headers))
-
     @inlineCallbacks
     def test__list_resources(self):
         driver = RSDPodDriver()
@@ -2088,32 +1958,6 @@ class TestRSDPodDriver(MAASTestCase):
             discovered_pod))
 
     @inlineCallbacks
-    def test__set_pxe_boot(self):
-        driver = RSDPodDriver()
-        context = make_context()
-        url = driver.get_url(context)
-        node_id = context.get('node_id').encode('utf-8')
-        headers = driver.make_auth_headers(**context)
-        mock_file_body_producer = self.patch(
-            rsd_module, 'FileBodyProducer')
-        payload = FileBodyProducer(
-            BytesIO(
-                json.dumps(
-                    {
-                        'Boot': {
-                            'BootSourceOverrideEnabled': "Once",
-                            'BootSourceOverrideTarget': "Pxe"
-                        }
-                    }).encode('utf-8')))
-        mock_file_body_producer.return_value = payload
-        mock_redfish_request = self.patch(driver, 'redfish_request')
-
-        yield driver.set_pxe_boot(url, node_id, headers)
-        self.assertThat(mock_redfish_request, MockCalledOnceWith(
-            b"PATCH", join(url, b"redfish/v1/Nodes/%s" % node_id),
-            headers, payload))
-
-    @inlineCallbacks
     def test__get_composed_node_state(self):
         driver = RSDPodDriver()
         context = make_context()
@@ -2220,10 +2064,9 @@ class TestRSDPodDriver(MAASTestCase):
             url, node_id, headers))
 
     @inlineCallbacks
-    def test_power_issues_power_reset(self):
+    def test__set_pxe_boot(self):
         driver = RSDPodDriver()
         context = make_context()
-        power_change = factory.make_name('power_change')
         url = driver.get_url(context)
         node_id = context.get('node_id').encode('utf-8')
         headers = driver.make_auth_headers(**context)
@@ -2233,15 +2076,18 @@ class TestRSDPodDriver(MAASTestCase):
             BytesIO(
                 json.dumps(
                     {
-                        'ResetType': "%s" % power_change
+                        'Boot': {
+                            'BootSourceOverrideEnabled': "Once",
+                            'BootSourceOverrideTarget': "Pxe"
+                        }
                     }).encode('utf-8')))
         mock_file_body_producer.return_value = payload
         mock_redfish_request = self.patch(driver, 'redfish_request')
-        expected_uri = join(
-            url, b"redfish/v1/Nodes/%s/Actions/ComposedNode.Reset" % node_id)
-        yield driver.power(power_change, url, node_id, headers)
+
+        yield driver.set_pxe_boot(url, node_id, headers)
         self.assertThat(mock_redfish_request, MockCalledOnceWith(
-            b"POST", expected_uri, headers, payload))
+            b"PATCH", join(url, b"redfish/v1/Nodes/%s" % node_id),
+            headers, payload))
 
     @inlineCallbacks
     def test__power_on(self):
diff --git a/src/provisioningserver/drivers/power/redfish.py b/src/provisioningserver/drivers/power/redfish.py
new file mode 100644
index 0000000..5b47e21
--- /dev/null
+++ b/src/provisioningserver/drivers/power/redfish.py
@@ -0,0 +1,217 @@
+# Copyright 2018 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Redfish Power Driver."""
+
+__all__ = [
+    'RedfishPowerDriver',
+    ]
+
+from base64 import b64encode
+from http import HTTPStatus
+from io import BytesIO
+import json
+from os.path import join
+
+from provisioningserver.drivers import (
+    make_ip_extractor,
+    make_setting_field,
+    SETTING_SCOPE,
+)
+from provisioningserver.drivers.power import (
+    PowerActionError,
+    PowerDriver,
+)
+from provisioningserver.utils.twisted import asynchronous
+from twisted.internet import reactor
+from twisted.internet._sslverify import (
+    ClientTLSOptions,
+    OpenSSLCertificateOptions,
+)
+from twisted.internet.defer import inlineCallbacks
+from twisted.web.client import (
+    Agent,
+    BrowserLikePolicyForHTTPS,
+    FileBodyProducer,
+    PartialDownloadError,
+    readBody,
+)
+from twisted.web.http_headers import Headers
+
+
+REDFISH_POWER_CONTROL_ENDPOINT = (
+    b"redfish/v1/Systems/%s/Actions/ComputerSystem.Reset/")
+
+REDFISH_SYSTEMS_ENDPOINT = b"redfish/v1/Systems/%s/"
+
+
+class WebClientContextFactory(BrowserLikePolicyForHTTPS):
+
+    def creatorForNetloc(self, hostname, port):
+        opts = ClientTLSOptions(
+            hostname.decode("ascii"),
+            OpenSSLCertificateOptions(verify=False).getContext())
+        # This forces Twisted to not validate the hostname of the certificate.
+        opts._ctx.set_info_callback(lambda *args: None)
+        return opts
+
+
+class RedfishPowerDriverBase(PowerDriver):
+
+    def get_url(self, context):
+        """Return url for the pod."""
+        url = context.get('power_address')
+        if "https" not in url and "http" not in url:
+            # Prepend https
+            url = join("https://", url)
+        return url.encode('utf-8')
+
+    def make_auth_headers(self, power_user, power_pass, **kwargs):
+        """Return authentication headers."""
+        creds = "%s:%s" % (power_user, power_pass)
+        authorization = b64encode(creds.encode('utf-8'))
+        return Headers(
+            {
+                b"User-Agent": [b"MAAS"],
+                b"Authorization": [b"Basic " + authorization],
+                b"Content-Type": [b"application/json; charset=utf-8"],
+            }
+        )
+
+    def process_redfish_context(self, context):
+        """Process Redfish power driver context."""
+        url = self.get_url(context)
+        node_id = context.get('node_id').encode('utf-8')
+        headers = self.make_auth_headers(**context)
+        return url, node_id, headers
+
+    @asynchronous
+    def redfish_request(self, method, uri, headers=None, bodyProducer=None):
+        """Send the redfish request and return the response."""
+        agent = Agent(reactor, contextFactory=WebClientContextFactory())
+        d = agent.request(
+            method, uri, headers=headers, bodyProducer=bodyProducer)
+
+        def render_response(response):
+            """Render the HTTPS response received."""
+
+            def eb_catch_partial(failure):
+                # Twisted is raising PartialDownloadError because the responses
+                # do not contain a Content-Length header. Since every response
+                # holds the whole body we just take the result.
+                failure.trap(PartialDownloadError)
+                if int(failure.value.status) == HTTPStatus.OK:
+                    return failure.value.response
+                else:
+                    return failure
+
+            def cb_json_decode(data):
+                data = data.decode('utf-8')
+                # Only decode non-empty response bodies.
+                if data:
+                    return json.loads(data)
+
+            def cb_attach_headers(data, headers):
+                return data, headers
+
+            # Error out if the response has a status code of 400 or above.
+            if response.code >= int(HTTPStatus.BAD_REQUEST):
+                raise PowerActionError(
+                    "Redfish request failed with response status code:"
+                    " %s." % response.code)
+
+            d = readBody(response)
+            d.addErrback(eb_catch_partial)
+            d.addCallback(cb_json_decode)
+            d.addCallback(cb_attach_headers, headers=response.headers)
+            return d
+
+        d.addCallback(render_response)
+        return d
+
+
+class RedfishPowerDriver(RedfishPowerDriverBase):
+
+    chassis = True  # Redfish API endpoints can be probed and enlisted.
+
+    name = 'redfish'
+    description = "Redfish"
+    settings = [
+        make_setting_field(
+            'power_address', "Redfish address", required=True),
+        make_setting_field('power_user', "Redfish user", required=True),
+        make_setting_field(
+            'power_pass', "Redfish password",
+            field_type='password', required=True),
+        make_setting_field(
+            'node_id', "Node ID",
+            scope=SETTING_SCOPE.NODE, required=True),
+    ]
+    ip_extractor = make_ip_extractor('power_address')
+
+    def detect_missing_packages(self):
+        # no required packages
+        return []
+
+    @inlineCallbacks
+    def set_pxe_boot(self, url, node_id, headers):
+        """Set the machine with node_id to PXE boot."""
+        endpoint = REDFISH_SYSTEMS_ENDPOINT % node_id
+        payload = FileBodyProducer(
+            BytesIO(
+                json.dumps(
+                    {
+                        'Boot': {
+                            'BootSourceOverrideEnabled': "Once",
+                            'BootSourceOverrideTarget': "Pxe"
+                        }
+                    }).encode('utf-8')))
+        yield self.redfish_request(
+            b"PATCH", join(url, endpoint), headers, payload)
+
+    @inlineCallbacks
+    def power(self, power_change, url, node_id, headers):
+        """Issue `power` command."""
+        endpoint = REDFISH_POWER_CONTROL_ENDPOINT % node_id
+        payload = FileBodyProducer(
+            BytesIO(
+                json.dumps(
+                    {
+                        'Action': "Reset",
+                        'ResetType': "%s" % power_change
+                    }).encode('utf-8')))
+        yield self.redfish_request(
+            b"POST", join(url, endpoint), headers, payload)
+
+    @asynchronous
+    @inlineCallbacks
+    def power_on(self, system_id, context):
+        """Power on machine."""
+        url, node_id, headers = self.process_redfish_context(context)
+        power_state = yield self.power_query(system_id, context)
+        # Power off the machine if currently on.
+        if power_state == 'on':
+            yield self.power("ForceOff", url, node_id, headers)
+        # Set to PXE boot.
+        yield self.set_pxe_boot(url, node_id, headers)
+        # Power on the machine.
+        yield self.power("On", url, node_id, headers)
+
+    @asynchronous
+    @inlineCallbacks
+    def power_off(self, system_id, context):
+        """Power off machine."""
+        url, node_id, headers = self.process_redfish_context(context)
+        # Set to PXE boot.
+        yield self.set_pxe_boot(url, node_id, headers)
+        # Power off the machine.
+        yield self.power("ForceOff", url, node_id, headers)
+
+    @asynchronous
+    @inlineCallbacks
+    def power_query(self, system_id, context):
+        """Power query machine."""
+        url, node_id, headers = self.process_redfish_context(context)
+        uri = join(url, REDFISH_SYSTEMS_ENDPOINT % node_id)
+        node_data, _ = yield self.redfish_request(b"GET", uri, headers)
+        return node_data.get('PowerState').lower()
diff --git a/src/provisioningserver/drivers/power/registry.py b/src/provisioningserver/drivers/power/registry.py
index 14a1136..78ddb92 100644
--- a/src/provisioningserver/drivers/power/registry.py
+++ b/src/provisioningserver/drivers/power/registry.py
@@ -22,6 +22,7 @@ from provisioningserver.drivers.power.mscm import MSCMPowerDriver
 from provisioningserver.drivers.power.msftocs import MicrosoftOCSPowerDriver
 from provisioningserver.drivers.power.nova import NovaPowerDriver
 from provisioningserver.drivers.power.recs import RECSPowerDriver
+from provisioningserver.drivers.power.redfish import RedfishPowerDriver
 from provisioningserver.drivers.power.seamicro import SeaMicroPowerDriver
 from provisioningserver.drivers.power.ucsm import UCSMPowerDriver
 from provisioningserver.drivers.power.virsh import VirshPowerDriver
@@ -61,6 +62,7 @@ power_drivers = [
     MicrosoftOCSPowerDriver(),
     NovaPowerDriver(),
     RECSPowerDriver(),
+    RedfishPowerDriver(),
     SeaMicroPowerDriver(),
     UCSMPowerDriver(),
     VirshPowerDriver(),
diff --git a/src/provisioningserver/drivers/power/tests/test_redfish.py b/src/provisioningserver/drivers/power/tests/test_redfish.py
new file mode 100644
index 0000000..f6db6e3
--- /dev/null
+++ b/src/provisioningserver/drivers/power/tests/test_redfish.py
@@ -0,0 +1,439 @@
+# Copyright 2018 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Tests for `provisioningserver.drivers.power.redfish`."""
+
+__all__ = []
+
+
+from base64 import b64encode
+from copy import deepcopy
+from http import HTTPStatus
+from io import BytesIO
+import json
+from os.path import join
+import random
+from unittest.mock import (
+    call,
+    Mock,
+)
+
+from maastesting.factory import factory
+from maastesting.matchers import (
+    MockCalledOnceWith,
+    MockCallsMatch,
+    MockNotCalled,
+)
+from maastesting.testcase import (
+    MAASTestCase,
+    MAASTwistedRunTest,
+)
+from provisioningserver.drivers.power import PowerActionError
+from provisioningserver.drivers.power.redfish import (
+    REDFISH_POWER_CONTROL_ENDPOINT,
+    RedfishPowerDriver,
+    WebClientContextFactory,
+)
+import provisioningserver.drivers.power.redfish as redfish_module
+from testtools import ExpectedException
+from twisted.internet._sslverify import ClientTLSOptions
+from twisted.internet.defer import (
+    fail,
+    inlineCallbacks,
+    succeed,
+)
+from twisted.web.client import (
+    FileBodyProducer,
+    PartialDownloadError,
+)
+from twisted.web.http_headers import Headers
+
+
+SAMPLE_JSON_SYSTEMS = {
+    "@odata.context": "/redfish/v1/$metadata#Systems",
+    "@odata.count": 1,
+    "@odata.id": "/redfish/v1/Systems",
+    "@odata.type": "#ComputerSystem.1.0.0.ComputerSystemCollection",
+    "Description": "Collection of Computer Systems",
+    "Members": [
+        {
+            "@odata.id": "/redfish/v1/Systems/1"
+        }
+    ],
+    "Name": "Computer System Collection"
+}
+
+SAMPLE_JSON_SYSTEM = {
+    "@odata.context": "/redfish/v1/$metadata#Systems/Members/$entity",
+    "@odata.id": "/redfish/v1/Systems/1",
+    "@odata.type": "#ComputerSystem.1.0.0.ComputerSystem",
+    "Actions": {
+        "#ComputerSystem.Reset": {
+            "[e-mail]": [
+                "On",
+                "ForceOff",
+                "GracefulRestart",
+                "PushPowerButton",
+                "Nmi"
+            ],
+            "target": "/redfish/v1/Systems/1/Actions/ComputerSystem.Reset"
+        }
+    },
+    "AssetTag": "",
+    "BiosVersion": "2.1.7",
+    "Boot": {
+        "BootSourceOverrideEnabled": "Once",
+        "BootSourceOverrideTarget": "None",
+        "[e-mail]": [
+            "None",
+            "Pxe",
+            "Floppy",
+            "Cd",
+            "Hdd",
+            "BiosSetup",
+            "Utilities",
+            "UefiTarget"
+        ],
+        "UefiTargetBootSourceOverride": ""
+    },
+    "Description": "Computer System which represents a machine.",
+    "EthernetInterfaces": {
+        "@odata.id": "/redfish/v1/Systems/1/EthernetInterfaces"
+    },
+    "HostName": "WORTHY-BOAR",
+    "Id": "1",
+    "IndicatorLED": "Off",
+    "Links": {
+        "Chassis": [
+            {
+                "@odata.id": "/redfish/v1/Chassis/1"
+            }
+        ],
+        "ManagedBy": [
+            {
+                "@odata.id": "/redfish/v1/Managers/iDRAC.Embedded.1"
+            }
+        ],
+        "PoweredBy": [
+            {
+                "@odata.id": "/redfish/v1/Chassis/1/Power/PowerSupplies/..."
+            },
+            {
+                "@odata.id": "/redfish/v1/Chassis/1/Power/PowerSupplies/..."
+            }
+        ]
+    },
+    "Manufacturer": "Dell Inc.",
+    "MemorySummary": {
+        "Status": {
+            "Health": "OK",
+            "HealthRollUp": "OK",
+            "State": "Enabled"
+        },
+        "TotalSystemMemoryGiB": 64
+    },
+    "Model": "PowerEdge R630",
+    "Name": "System",
+    "PartNumber": "02C2CPA01",
+    "PowerState": "Off",
+    "ProcessorSummary": {
+        "Count": 2,
+        "Model": "Intel(R) Xeon(R) CPU E5-2667 v4 @ 3.20GHz",
+        "Status": {
+            "Health": "Critical",
+            "HealthRollUp": "Critical",
+            "State": "Enabled"
+        }
+    },
+    "Processors": {
+        "@odata.id": "/redfish/v1/Systems/1/Processors"
+    },
+    "SKU": "7PW1RD2",
+    "SerialNumber": "CN7475166I0364",
+    "SimpleStorage": {
+        "@odata.id": "/redfish/v1/Systems/1/Storage/Controllers"
+    },
+    "Status": {
+        "Health": "Critical",
+        "HealthRollUp": "Critical",
+        "State": "Offline"
+    },
+    "SystemType": "Physical",
+    "UUID": "4c4c4544-0050-5710-8031-b7c04f524432"
+}
+
+
+def make_context():
+    return {
+        'power_address': factory.make_ipv4_address(),
+        'power_user': factory.make_name('power_user'),
+        'power_pass': factory.make_name('power_pass'),
+        'node_id': factory.make_name('node_id'),
+    }
+
+
+class TestWebClientContextFactory(MAASTestCase):
+
+    def test_creatorForNetloc_returns_tls_options(self):
+        hostname = factory.make_name('hostname').encode('utf-8')
+        port = random.randint(1000, 2000)
+        contextFactory = WebClientContextFactory()
+        opts = contextFactory.creatorForNetloc(hostname, port)
+        self.assertIsInstance(opts, ClientTLSOptions)
+
+
+class TestRedfishPowerDriver(MAASTestCase):
+
+    run_tests_with = MAASTwistedRunTest.make_factory(timeout=5)
+
+    def test_missing_packages(self):
+        # there's nothing to check for, just confirm it returns []
+        driver = RedfishPowerDriver()
+        missing = driver.detect_missing_packages()
+        self.assertItemsEqual([], missing)
+
+    def test_get_url_with_ip(self):
+        driver = RedfishPowerDriver()
+        context = make_context()
+        ip = context.get('power_address').encode('utf-8')
+        expected_url = b"https://%s" % ip
+        url = driver.get_url(context)
+        self.assertEqual(expected_url, url)
+
+    def test_get_url_with_https(self):
+        driver = RedfishPowerDriver()
+        context = make_context()
+        context['power_address'] = join(
+            "https://", context['power_address'])
+        expected_url = context.get('power_address').encode('utf-8')
+        url = driver.get_url(context)
+        self.assertEqual(expected_url, url)
+
+    def test_get_url_with_http(self):
+        driver = RedfishPowerDriver()
+        context = make_context()
+        context['power_address'] = join(
+            "http://", context['power_address'])
+        expected_url = context.get('power_address').encode('utf-8')
+        url = driver.get_url(context)
+        self.assertEqual(expected_url, url)
+
+    def test__make_auth_headers(self):
+        power_user = factory.make_name('power_user')
+        power_pass = factory.make_name('power_pass')
+        creds = "%s:%s" % (power_user, power_pass)
+        authorization = b64encode(creds.encode('utf-8'))
+        attributes = {
+            b"User-Agent": [b"MAAS"],
+            b"Authorization": [b"Basic " + authorization],
+            b"Content-Type": [b"application/json; charset=utf-8"],
+        }
+        driver = RedfishPowerDriver()
+        headers = driver.make_auth_headers(power_user, power_pass)
+        self.assertEquals(headers, Headers(attributes))
+
+    @inlineCallbacks
+    def test_redfish_request_renders_response(self):
+        driver = RedfishPowerDriver()
+        context = make_context()
+        url = driver.get_url(context)
+        uri = join(url, b"redfish/v1/Systems")
+        headers = driver.make_auth_headers(**context)
+        mock_agent = self.patch(redfish_module, 'Agent')
+        mock_agent.return_value.request = Mock()
+        expected_headers = Mock()
+        expected_headers.code = HTTPStatus.OK
+        expected_headers.headers = "Testing Headers"
+        mock_agent.return_value.request.return_value = succeed(
+            expected_headers)
+        mock_readBody = self.patch(redfish_module, 'readBody')
+        mock_readBody.return_value = succeed(
+            json.dumps(SAMPLE_JSON_SYSTEMS).encode('utf-8'))
+        expected_response = SAMPLE_JSON_SYSTEMS
+
+        response, headers = yield driver.redfish_request(b"GET", uri, headers)
+        self.assertEquals(expected_response, response)
+        self.assertEquals(expected_headers.headers, headers)
+
+    @inlineCallbacks
+    def test_redfish_request_continues_partial_download_error(self):
+        driver = RedfishPowerDriver()
+        context = make_context()
+        url = driver.get_url(context)
+        uri = join(url, b"redfish/v1/Systems")
+        headers = driver.make_auth_headers(**context)
+        mock_agent = self.patch(redfish_module, 'Agent')
+        mock_agent.return_value.request = Mock()
+        expected_headers = Mock()
+        expected_headers.code = HTTPStatus.OK
+        expected_headers.headers = "Testing Headers"
+        mock_agent.return_value.request.return_value = succeed(
+            expected_headers)
+        mock_readBody = self.patch(redfish_module, 'readBody')
+        error = PartialDownloadError(
+            response=json.dumps(SAMPLE_JSON_SYSTEMS).encode('utf-8'),
+            code=HTTPStatus.OK)
+        mock_readBody.return_value = fail(error)
+        expected_response = SAMPLE_JSON_SYSTEMS
+
+        response, headers = yield driver.redfish_request(b"GET", uri, headers)
+        self.assertEquals(expected_response, response)
+        self.assertEquals(expected_headers.headers, headers)
+
+    @inlineCallbacks
+    def test_redfish_request_raises_failures(self):
+        driver = RedfishPowerDriver()
+        context = make_context()
+        url = driver.get_url(context)
+        uri = join(url, b"redfish/v1/Systems")
+        headers = driver.make_auth_headers(**context)
+        mock_agent = self.patch(redfish_module, 'Agent')
+        mock_agent.return_value.request = Mock()
+        expected_headers = Mock()
+        expected_headers.code = HTTPStatus.OK
+        expected_headers.headers = "Testing Headers"
+        mock_agent.return_value.request.return_value = succeed(
+            expected_headers)
+        mock_readBody = self.patch(redfish_module, 'readBody')
+        error = PartialDownloadError(
+            response=json.dumps(SAMPLE_JSON_SYSTEMS).encode('utf-8'),
+            code=HTTPStatus.NOT_FOUND)
+        mock_readBody.return_value = fail(error)
+
+        with ExpectedException(PartialDownloadError):
+            yield driver.redfish_request(b"GET", uri, headers)
+        self.assertThat(mock_readBody, MockCalledOnceWith(
+            expected_headers))
+
+    @inlineCallbacks
+    def test_redfish_request_raises_error_on_response_code_above_400(self):
+        driver = RedfishPowerDriver()
+        context = make_context()
+        url = driver.get_url(context)
+        uri = join(url, b"redfish/v1/Systems")
+        headers = driver.make_auth_headers(**context)
+        mock_agent = self.patch(redfish_module, 'Agent')
+        mock_agent.return_value.request = Mock()
+        expected_headers = Mock()
+        expected_headers.code = HTTPStatus.BAD_REQUEST
+        expected_headers.headers = "Testing Headers"
+        mock_agent.return_value.request.return_value = succeed(
+            expected_headers)
+        mock_readBody = self.patch(redfish_module, 'readBody')
+
+        with ExpectedException(PowerActionError):
+            yield driver.redfish_request(b"GET", uri, headers)
+        self.assertThat(mock_readBody, MockNotCalled())
+
+    @inlineCallbacks
+    def test_power_issues_power_reset(self):
+        driver = RedfishPowerDriver()
+        context = make_context()
+        power_change = factory.make_name('power_change')
+        url = driver.get_url(context)
+        headers = driver.make_auth_headers(**context)
+        node_id = context.get('node_id').encode('utf-8')
+        mock_file_body_producer = self.patch(
+            redfish_module, 'FileBodyProducer')
+        payload = FileBodyProducer(
+            BytesIO(
+                json.dumps(
+                    {
+                        'ResetType': "%s" % power_change
+                    }).encode('utf-8')))
+        mock_file_body_producer.return_value = payload
+        mock_redfish_request = self.patch(driver, 'redfish_request')
+        expected_uri = join(
+            url, REDFISH_POWER_CONTROL_ENDPOINT % node_id)
+        yield driver.power(power_change, url, node_id, headers)
+        self.assertThat(mock_redfish_request, MockCalledOnceWith(
+            b"POST", expected_uri, headers, payload))
+
+    @inlineCallbacks
+    def test__set_pxe_boot(self):
+        driver = RedfishPowerDriver()
+        context = make_context()
+        url = driver.get_url(context)
+        node_id = context.get('node_id').encode('utf-8')
+        headers = driver.make_auth_headers(**context)
+        mock_file_body_producer = self.patch(
+            redfish_module, 'FileBodyProducer')
+        payload = FileBodyProducer(
+            BytesIO(
+                json.dumps(
+                    {
+                        'Boot': {
+                            'BootSourceOverrideEnabled': "Once",
+                            'BootSourceOverrideTarget': "Pxe"
+                        }
+                    }).encode('utf-8')))
+        mock_file_body_producer.return_value = payload
+        mock_redfish_request = self.patch(driver, 'redfish_request')
+
+        yield driver.set_pxe_boot(url, node_id, headers)
+        self.assertThat(mock_redfish_request, MockCalledOnceWith(
+            b"PATCH", join(url, b"redfish/v1/Systems/%s/" % node_id),
+            headers, payload))
+
+    @inlineCallbacks
+    def test__power_on(self):
+        driver = RedfishPowerDriver()
+        system_id = factory.make_name('system_id')
+        context = make_context()
+        url = driver.get_url(context)
+        headers = driver.make_auth_headers(**context)
+        node_id = context.get('node_id').encode('utf-8')
+        mock_set_pxe_boot = self.patch(driver, 'set_pxe_boot')
+        mock_power_query = self.patch(driver, 'power_query')
+        mock_power_query.return_value = "on"
+        mock_power = self.patch(driver, 'power')
+
+        yield driver.power_on(system_id, context)
+        self.assertThat(mock_set_pxe_boot, MockCalledOnceWith(
+            url, node_id, headers))
+        self.assertThat(mock_power_query, MockCalledOnceWith(
+            system_id, context))
+        self.assertThat(mock_power, MockCallsMatch(
+            call("ForceOff", url, node_id, headers),
+            call("On", url, node_id, headers)))
+
+    @inlineCallbacks
+    def test__power_off(self):
+        driver = RedfishPowerDriver()
+        system_id = factory.make_name('system_id')
+        context = make_context()
+        url = driver.get_url(context)
+        headers = driver.make_auth_headers(**context)
+        node_id = context.get('node_id').encode('utf-8')
+        mock_set_pxe_boot = self.patch(driver, 'set_pxe_boot')
+        mock_power = self.patch(driver, 'power')
+
+        yield driver.power_off(system_id, context)
+        self.assertThat(mock_set_pxe_boot, MockCalledOnceWith(
+            url, node_id, headers))
+        self.assertThat(mock_power, MockCalledOnceWith(
+            "ForceOff", url, node_id, headers))
+
+    @inlineCallbacks
+    def test_power_query_queries_on(self):
+        driver = RedfishPowerDriver()
+        power_change = "On"
+        system_id = factory.make_name('system_id')
+        context = make_context()
+        mock_redfish_request = self.patch(driver, 'redfish_request')
+        NODE_POWERED_ON = deepcopy(SAMPLE_JSON_SYSTEM)
+        NODE_POWERED_ON['PowerState'] = "On"
+        mock_redfish_request.return_value = (NODE_POWERED_ON, None)
+        power_state = yield driver.power_query(system_id, context)
+        self.assertEquals(power_state, power_change.lower())
+
+    @inlineCallbacks
+    def test_power_query_queries_off(self):
+        driver = RedfishPowerDriver()
+        power_change = "Off"
+        system_id = factory.make_name('system_id')
+        context = make_context()
+        mock_redfish_request = self.patch(driver, 'redfish_request')
+        mock_redfish_request.return_value = (SAMPLE_JSON_SYSTEM, None)
+        power_state = yield driver.power_query(system_id, context)
+        self.assertEquals(power_state, power_change.lower())