Merge ~newell-jensen/maas:lp1777742 into maas:master

Proposed by Newell Jensen
Status: Merged
Approved by: Newell Jensen
Approved revision: 5d4c6528a65f8374c5347dc6d1af5f983cad1679
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~newell-jensen/maas:lp1777742
Merge into: maas:master
Diff against target: 30 lines (+4/-4)
2 files modified
src/provisioningserver/drivers/pod/tests/test_virsh.py (+2/-3)
src/provisioningserver/drivers/pod/virsh.py (+2/-1)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
MAAS Lander unittests Pending
Review via email: mp+349214@code.launchpad.net

Commit message

LP: #1777742 -- Add nvram flag to virsh undefine command so that when the virsh domain is undefined it will remove the nvram file, if it is inactive.

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/provisioningserver/drivers/pod/tests/test_virsh.py b/src/provisioningserver/drivers/pod/tests/test_virsh.py
2index 60bf860..a46f0a0 100644
3--- a/src/provisioningserver/drivers/pod/tests/test_virsh.py
4+++ b/src/provisioningserver/drivers/pod/tests/test_virsh.py
5@@ -1581,9 +1581,8 @@ class TestVirshSSH(MAASTestCase):
6 self.assertThat(mock_run, MockCallsMatch(
7 call(['destroy', domain]),
8 call([
9- 'undefine', domain,
10- '--remove-all-storage',
11- '--managed-save'])))
12+ 'undefine', domain, '--remove-all-storage',
13+ '--managed-save', '--nvram'])))
14
15
16 class TestVirsh(MAASTestCase):
17diff --git a/src/provisioningserver/drivers/pod/virsh.py b/src/provisioningserver/drivers/pod/virsh.py
18index aa88121..a19e0aa 100644
19--- a/src/provisioningserver/drivers/pod/virsh.py
20+++ b/src/provisioningserver/drivers/pod/virsh.py
21@@ -986,7 +986,8 @@ class VirshSSH(pexpect.spawn):
22 # Removed the --delete-snapshots flag to workaround the volumes not
23 # being deleted. See the bug for more details.
24 self.run([
25- 'undefine', domain, '--remove-all-storage', '--managed-save'])
26+ 'undefine', domain, '--remove-all-storage',
27+ '--managed-save', '--nvram'])
28
29
30 class VirshPodDriver(PodDriver):

Subscribers

People subscribed via source and target branches