Merge lp:~neric27/midori/cflags_in_c_extensions into lp:midori

Proposed by Eric Le Lay
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6578
Merged at revision: 6578
Proposed branch: lp:~neric27/midori/cflags_in_c_extensions
Merge into: lp:midori
Diff against target: 27 lines (+11/-3)
1 file modified
extensions/CMakeLists.txt (+11/-3)
To merge this branch: bzr merge lp:~neric27/midori/cflags_in_c_extensions
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+208968@code.launchpad.net

Commit message

Set proper CFLAGS for vala and c files when compiling extensions

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'extensions/CMakeLists.txt'
--- extensions/CMakeLists.txt 2014-03-01 17:55:02 +0000
+++ extensions/CMakeLists.txt 2014-03-02 16:17:23 +0000
@@ -69,12 +69,20 @@
69 target_link_libraries(${UNIT_SRC}69 target_link_libraries(${UNIT_SRC}
70 ${LIBMIDORI}70 ${LIBMIDORI}
71 )71 )
72 set_target_properties(${UNIT_SRC} PROPERTIES
73 COMPILE_FLAGS ${VALA_CFLAGS}
74 )
75 install(TARGETS ${UNIT_SRC}72 install(TARGETS ${UNIT_SRC}
76 LIBRARY DESTINATION ${EXTENSIONDIR}73 LIBRARY DESTINATION ${EXTENSIONDIR}
77 )74 )
75 # extensions with vala code get the lenient VALA_CFLAGS
76 # others get the usual CFLAGS with -Wall and -Werror
77 if (UNIT_FILES_VALA)
78 set_target_properties(${UNIT_SRC} PROPERTIES
79 COMPILE_FLAGS ${VALA_CFLAGS}
80 )
81 else ()
82 set_target_properties(${UNIT_SRC} PROPERTIES
83 COMPILE_FLAGS ${CFLAGS}
84 )
85 endif ()
78 endif ()86 endif ()
79 endif ()87 endif ()
80endforeach ()88endforeach ()

Subscribers

People subscribed via source and target branches

to all changes: