Merge lp:~nerd65536/byobu/trunk into lp:byobu

Proposed by Simon Elmir on 2018-10-19
Status: Merged
Merge reported by: Dustin Kirkland 
Merged at revision: not available
Proposed branch: lp:~nerd65536/byobu/trunk
Merge into: lp:byobu
Diff against target: 12 lines (+1/-1)
1 file modified
usr/share/byobu/profiles/bashrc (+1/-1)
To merge this branch: bzr merge lp:~nerd65536/byobu/trunk
Reviewer Review Type Date Requested Status
Dustin Kirkland  2018-10-19 Approve on 2019-03-19
Review via email: mp+357122@code.launchpad.net

Commit message

Add missing escape to non-Ubuntu PS1

Description of the change

usr/share/byobu/profiles/bashrc's PS1 for non-Ubuntu systems is missing a \[ near the end of the prompt

All non-printed characters, like color codes, should be wrapped in \[...\] so the length of the prompt can be calculated properly. Without the wrapping, things like scrolling back and forth through history will appear glitchy.

This commit adds the missing \[.

To post a comment you must log in.
Dustin Kirkland  (kirkland) wrote :

Great catch, thanks! This is merged and committed and will be released in 5.128.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'usr/share/byobu/profiles/bashrc'
--- usr/share/byobu/profiles/bashrc 2018-08-12 16:32:34 +0000
+++ usr/share/byobu/profiles/bashrc 2018-10-19 04:21:15 +0000
@@ -54,7 +54,7 @@
54 ;;54 ;;
55 *)55 *)
56 # Use Googley colors (blue / red / yellow / blue / green / red )56 # Use Googley colors (blue / red / yellow / blue / green / red )
57 PS1="${debian_chroot:+($debian_chroot)}\[\e[31m\]\$(byobu_prompt_status)\[\e[38;5;69m\]\u\[\e[38;5;214m\]@\[\e[38;5;167m\]\h\[\e[38;5;214m\]:\[\e[38;5;71m\]\w\[\e[38;5;214m\]\$(byobu_prompt_symbol)\e[00m\] "57 PS1="${debian_chroot:+($debian_chroot)}\[\e[31m\]\$(byobu_prompt_status)\[\e[38;5;69m\]\u\[\e[38;5;214m\]@\[\e[38;5;167m\]\h\[\e[38;5;214m\]:\[\e[38;5;71m\]\w\[\e[38;5;214m\]\$(byobu_prompt_symbol)\[\e[00m\] "
58 ;;58 ;;
59 esac59 esac
60 fi60 fi

Subscribers

People subscribed via source and target branches