Ubuntu Weather App

Merge lp:~neokore/ubuntu-weather-app/AvoidThemeChange into lp:ubuntu-weather-app/obsolete.trunk

  1. AvoidThemeChange
  2. Merge into trunk
Proposed by Raúl Yeguas
Status: Merged
Approved by: Martin Borho
Approved revision: 134
Merged at revision: 137
Proposed branch: lp:~neokore/ubuntu-weather-app/AvoidThemeChange
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 40 lines (+15/-15)
1 file modified
components/GradientsMap.js (+15/-15)
To merge this branch: bzr merge lp:~neokore/ubuntu-weather-app/AvoidThemeChange
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Martin Borho Approve
Review via email: mp+189402@code.launchpad.net

Commit message

Updated colors in GradientsMap.js to darken those that have high
luminance. Fixes bug #1226746 and maybe #1213043 for the Weather-App as
long as we don't change the background.

Description of the change

Updated colors in GradientsMap.js to darken those that have high
luminance. Fixes bug #1226746 and maybe #1213043 for the Weather-App as
long as we don't change the background.

To post a comment you must log in.
Revision history for this message
Martin Borho (martin-borho) wrote :

Very good! Fits perfect, feels much better now!

review: Approve
Revision history for this message
Martin Borho (martin-borho) wrote :

Bug #1213043 bites us only, if we use for the same color for header, background and footer.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:134
http://91.189.93.70:8080/job/ubuntu-weather-app-ci/65/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests/688
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-precise-amd64-ci/63
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-quantal-amd64-ci/63
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-raring-amd64-ci/63
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-saucy-amd64-ci/63

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-ci/65/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:134
http://91.189.93.70:8080/job/ubuntu-weather-app-ci/79/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests/768
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-precise-amd64-ci/77
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-quantal-amd64-ci/77
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-raring-amd64-ci/77
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-saucy-amd64-ci/77

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-ci/79/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'components/GradientsMap.js'
--- components/GradientsMap.js 2013-09-28 10:32:31 +0000
+++ components/GradientsMap.js 2013-10-04 18:43:38 +0000
@@ -29,21 +29,21 @@
29 "24": "#c30213",29 "24": "#c30213",
30 "22": "#d8070c",30 "22": "#d8070c",
31 "20": "#e91109",31 "20": "#e91109",
32 "18": "#f52109",32 "18": "#E11D07",
33 "16": "#fb350e",33 "16": "#DD2B0C",
34 "14": "#fe4e17",34 "14": "#E04414",
35 "12": "#ff6721",35 "12": "#E1581D",
36 "10": "#ff812c",36 "10": "#E17126",
37 "8": "#ff983a",37 "8": "#E18433",
38 "6": "#ffae47",38 "6": "#E1983E",
39 "4": "#ffc056",39 "4": "#E1A84C",
40 "2": "#ffd067",40 "2": "#E1B75B",
41 "0": "#ffdc77",41 "0": "#E1C169",
42 "-2": "#ffe788",42 "-2": "#E1CB78",
43 "-4": "#fdf5a1",43 "-4": "#DFD78E",
44 "-6": "#effdbc",44 "-6": "#D4DFA6",
45 "-8": "#ccf7bb",45 "-8": "#B3D9A4",
46 "-10": "#a6eeb8",46 "-10": "#91D0A1",
47 "-12": "#85e4bd",47 "-12": "#85e4bd",
48 "-14": "#64d9c9",48 "-14": "#64d9c9",
49 "-16": "#43c9d3",49 "-16": "#43c9d3",

Subscribers

People subscribed via source and target branches