The Open Compute Project

Code review comment for lp:~nelson-chu/opencompute/add-ocp-cpu-memory-job

  1. add-ocp-cpu-memory-job
  2. Merge into checkbox
Revision history for this message
Nelson Chu (nelson-chu) wrote :

Hi Jeff,

Sorry to late reply...

1.) Changelog is very important, I am great to participate this part.

2.) Due to I don't have other ocp platform, I cannot ensure the script works fine with other ocp servers.

I revised the memory_info script, if still has problems please tell me.

3.) Thanks your advice, it helps me to learn more.

review: Needs Resubmitting

« Back to merge proposal