The Open Compute Project

Code review comment for lp:~nelson-chu/opencompute/add-ocp-cpu-memory-job

  1. add-ocp-cpu-memory-job
  2. Merge into checkbox
Revision history for this message
Jeff Lane  (bladernr) wrote :

Before I can go any further, you have a conflict in data/whitelists/opencompute-certify-local.whitelist

To see this, you should do the following:

bzr branch lp:opencompute/checkbox ocp-checkbox
cd ocp-checkbox
bzr merge lp:~nelson-chu/opencompute/add-ocp-cpu-memory-job

That MAY actually just clean it up... but there's a file conflict in there. so please resolve that and I'll review the rest at that time.

review: Needs Fixing

« Back to merge proposal