Code review comment for lp:~neil-aldur/ubuntu/precise/iptables-persistent/fix-for-967018-905517

On 19 April 2012 12:53, Chow Loong Jin <email address hidden> wrote:
> I'm not sure [ ! -e /etc/iptables/rules -o -e /etc/iptables/rules.v4 ] is correct. Why do we need to touch /etc/iptables/rules.v4 if it already exists?
>
> Also, I don't really like the idea of automatically removing the rules.v4.dpkg-new file, even if it is empty. I feel that the .dpkg-new and .dpkg-old files are the domain of the administrator, and should not be touched by scripts.
> --
> https://code.launchpad.net/~neil-aldur/ubuntu/precise/iptables-persistent/fix-for-967018-905517/+merge/100652
> You are the owner of lp:~neil-aldur/ubuntu/precise/iptables-persistent/fix-for-967018-905517.

Read the code carefully. It's an || after the test. That's the
condition for *not* touching the file.

And as I said, I've tested this, and it works.

Debian disagree with you. The empty dpkg-new files and the alterations
it put in place in this package is what caused all the fun in the
first place.

See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612278

--
Neil Wilson