Code review comment for lp:~ndurner/bzr/bzr-ftp

Revision history for this message
Nils Durner (ndurner) wrote :

> OK it's fairly obvious but a comment here would be good, especially because
> it's "might have append", not necessarily "has append".

Added in r4540.

> This seems to be treating *any* permission error on append

Any perm*anent* error, yes.
r4541 checks the actual reply code, in accordance to RFC 959 and 640.

> Also to help debug this it might be good to include e in the message.

r4542 has an extra mutter() in place, is that okay?



« Back to merge proposal