Code review comment for lp:~nchohan/appscale/appscale-1.6

Revision history for this message
Chris Bunch (cgb-cs) wrote :

More style stuff:

djinn_job_data, nginx, and pbserver looks good to me

In haproxy.rb, you've got these lines:

+ # Timeout a request if Mongrel does not accept a connection for 60 seconds
+ timeout connect 60000

which seem to indicate that the value is msec - 60000 msec -> 60 sec

but this doesn't seem to hold for the other vals:

+ # Timeout a request if the client did not read any data for 240 seconds
+ timeout client 60000

why isn't the above 60 seconds as well?

In terminate.rb, this whole block:

+#begin
+# require 'rabbitmq'
+# RabbitMQ.stop
+#rescue Execption
+# puts "Problem with rabbitmq, moving on"
+#end
+

is commented out, so just delete it.

In djinn.rb:

1) Remove "Djinn.rb" from all log_debug statements, since it isn't consistently applied (and other files don't identify themselves) and isn't standard for us.

review: Needs Fixing

« Back to merge proposal