2) On line 15, shouldn't the semi-colons be double ampersands? Don't you want to only exec the second command if the first succeeds?
3) Lines 20-21 are commented out since you're not using god to manage rabbitmq - thus, remove those and 16-18, since you're defining variables that you're not using.
4) On 11, 25, and 54, you don't need to pass in the secret - functions can get it with HelperFunctions.get_secret()
5) On line 30, extract the rabbitmq port to a global constant
A few style comments:
In rabbitmq.rb:
1) On line 11, remove the trailing space.
2) On line 15, shouldn't the semi-colons be double ampersands? Don't you want to only exec the second command if the first succeeds?
3) Lines 20-21 are commented out since you're not using god to manage rabbitmq - thus, remove those and 16-18, since you're defining variables that you're not using.
4) On 11, 25, and 54, you don't need to pass in the secret - functions can get it with HelperFunctions .get_secret( )
5) On line 30, extract the rabbitmq port to a global constant
6) Remove line 41, since you don't use it.
7) Remove line 50
8) Remove line 63