Zorba

Merge lp:~nbrinza/zorba/bugs2 into lp:zorba

  1. bugs2
  2. Merge into trunk
Proposed by Nicolae Brinza
Status: Superseded
Proposed branch: lp:~nbrinza/zorba/bugs2
Merge into: lp:zorba
Diff against target: 42 lines (+16/-16)
1 file modified
test/fots/CMakeLists.txt (+16/-16)
To merge this branch: bzr merge lp:~nbrinza/zorba/bugs2
Reviewer Review Type Date Requested Status
Sorin Marian Nasoi Approve
Nicolae Brinza Approve
Review via email: mp+160440@code.launchpad.net

This proposal has been superseded by a proposal from 2013-04-23.

Commit message

Added W3C bug reference in disputed bugs

Description of the change

Added W3C bug reference in disputed bugs

To post a comment you must log in.
Revision history for this message
Nicolae Brinza (nbrinza) :
review: Approve
Revision history for this message
Sorin Marian Nasoi (sorin.marian.nasoi) wrote :

The disputed test cases have to be logged as:
EXPECTED_FOTS_FAILURE (DISPUTED TEST_SET_NAME TEST_CASE_NAME W3C_BUG_NO)

Please see:
- http://bazaar.launchpad.net/~zorba-coders/zorba/trunk/view/head:/test/fots/CMakeLists.txt#L118
- https://bugs.launchpad.net/zorba/+bug/1147547/comments/5

Also this merge proposal is a fix for lp:1147547: can you please rename the branch to something unique? As you can see LP assumes that you have a branch called bugs2 that you regularly merge into the trunk. That is why the history from LP links 'bugs2' branch to every bug that was fixed from a branch with name 'bugs2'.

review: Needs Fixing
Revision history for this message
Sorin Marian Nasoi (sorin.marian.nasoi) wrote :

I would have corrected the changes in test/CMakeLists.txt myself if the branch owner would have been zorba-coders.

Like it is now, only you can commit to this branch.

lp:~nbrinza/zorba/bugs2 updated
11028. By Nicolae Brinza

Added DISPUTED to the tests that pend on W3C bugs

Revision history for this message
Nicolae Brinza (nbrinza) wrote :

I've added DISPUTED to the tests.

Revision history for this message
Sorin Marian Nasoi (sorin.marian.nasoi) :
review: Approve
lp:~nbrinza/zorba/bugs2 updated
11029. By Nicolae Brinza

Merged with Zorba trunk

11030. By Nicolae Brinza

Merged with the fix_bug_1167641 branch

Unmerged revisions

11030. By Nicolae Brinza

Merged with the fix_bug_1167641 branch

11029. By Nicolae Brinza

Merged with Zorba trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'test/fots/CMakeLists.txt'
--- test/fots/CMakeLists.txt 2013-04-23 13:55:03 +0000
+++ test/fots/CMakeLists.txt 2013-04-23 17:30:36 +0000
@@ -325,22 +325,22 @@
325EXPECTED_FOTS_FAILURE (prod-FunctionCall function-call-reserved-function-names-014 0)325EXPECTED_FOTS_FAILURE (prod-FunctionCall function-call-reserved-function-names-014 0)
326EXPECTED_FOTS_FAILURE (prod-FunctionCall function-call-reserved-function-names-015 0)326EXPECTED_FOTS_FAILURE (prod-FunctionCall function-call-reserved-function-names-015 0)
327EXPECTED_FOTS_FAILURE (prod-FunctionCall function-call-reserved-function-names-016 0)327EXPECTED_FOTS_FAILURE (prod-FunctionCall function-call-reserved-function-names-016 0)
328EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-001 0)328EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-001 21568)
329EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-003 0)329EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-003 21568)
330EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-005 0)330EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-005 21568)
331EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-007 0)331EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-007 21568)
332EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-009 0)332EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-009 21568)
333EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-012 0)333EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-012 21568)
334EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-013 0)334EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-013 21568)
335EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-015 0)335EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-015 21568)
336EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-017 0)336EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-017 21568)
337EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-019 0)337EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-019 21568)
338EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-021 0)338EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-021 21568)
339EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-023 0)339EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-023 21568)
340EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-025 0)340EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-025 21568)
341EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-027 0)341EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-027 21568)
342EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-029 0)342EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-029 21568)
343EXPECTED_FOTS_FAILURE (prod-FunctionDecl function-decl-reserved-function-names-031 0)343EXPECTED_FOTS_FAILURE (DISPUTED prod-FunctionDecl function-decl-reserved-function-names-031 21568)
344EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof113 0)344EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof113 0)
345EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof131 0)345EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof131 0)
346EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof139 1160559)346EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof139 1160559)

Subscribers

People subscribed via source and target branches