Merge lp:~nbessi-c2c-deactivatedaccount/account-invoice-report/account-invoice-report-fix-html-fields-and-css into lp:~account-core-editors/account-invoice-report/7.0

Proposed by Nicolas Bessi - Camptocamp
Status: Merged
Approved by: Joël Grand-Guillaume @ camptocamp
Approved revision: 11
Merge reported by: Joël Grand-Guillaume @ camptocamp
Merged at revision: not available
Proposed branch: lp:~nbessi-c2c-deactivatedaccount/account-invoice-report/account-invoice-report-fix-html-fields-and-css
Merge into: lp:~account-core-editors/account-invoice-report/7.0
Diff against target: 63 lines (+8/-6)
2 files modified
invoice_webkit/invoice.py (+3/-3)
invoice_webkit/report/account_invoice.mako (+5/-3)
To merge this branch: bzr merge lp:~nbessi-c2c-deactivatedaccount/account-invoice-report/account-invoice-report-fix-html-fields-and-css
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp no test, code review Approve
Review via email: mp+144706@code.launchpad.net

Description of the change

Account invoice text use html fields + small css glitch

To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Seems fine to me

review: Approve (no test, code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'invoice_webkit/invoice.py'
--- invoice_webkit/invoice.py 2013-01-15 08:16:58 +0000
+++ invoice_webkit/invoice.py 2013-01-24 14:21:25 +0000
@@ -40,7 +40,7 @@
40 ('footer', 'Bottom condition')],40 ('footer', 'Bottom condition')],
41 'type', required=True),41 'type', required=True),
4242
43 'text': fields.text('Condition', translate=True, required=True)}43 'text': fields.html('Condition', translate=True, required=True)}
4444
45class AccountInvoice(Model):45class AccountInvoice(Model):
46 """ Add account.condition_text to invoice"""46 """ Add account.condition_text to invoice"""
@@ -66,8 +66,8 @@
6666
67 _columns = {'text_condition1': fields.many2one('account.condition_text', 'Header condition'),67 _columns = {'text_condition1': fields.many2one('account.condition_text', 'Header condition'),
68 'text_condition2': fields.many2one('account.condition_text', 'Footer condition'),68 'text_condition2': fields.many2one('account.condition_text', 'Footer condition'),
69 'note1': fields.text('Header'),69 'note1': fields.html('Header'),
70 'note2': fields.text('Footer'),}70 'note2': fields.html('Footer'),}
7171
7272
73class AccountInvoiceLine(Model):73class AccountInvoiceLine(Model):
7474
=== modified file 'invoice_webkit/report/account_invoice.mako'
--- invoice_webkit/report/account_invoice.mako 2013-01-15 08:16:58 +0000
+++ invoice_webkit/report/account_invoice.mako 2013-01-24 14:21:25 +0000
@@ -32,6 +32,8 @@
3232
33.formatted_note {33.formatted_note {
34 border-right:thin solid #EEEEEE;34 border-right:thin solid #EEEEEE;
35 border-left:thin solid #EEEEEE;
36 border-top:thin solid #EEEEEE;
35 left:10px;37 left:10px;
36 font-size:smaller;38 font-size:smaller;
37}39}
@@ -178,7 +180,7 @@
178 <div>180 <div>
179181
180 %if inv.note1 :182 %if inv.note1 :
181 <p class="std_text"> ${inv.note1 | carriage_returns} </p>183 <p class="std_text"> ${inv.note1 | n} </p>
182 %endif184 %endif
183 </div>185 </div>
184 <h1 style="clear: both; padding-top: 20px;">186 <h1 style="clear: both; padding-top: 20px;">
@@ -240,7 +242,7 @@
240 </tr>242 </tr>
241 %if line.formatted_note:243 %if line.formatted_note:
242 <tr>244 <tr>
243 <td class="formatted_note">245 <td class="formatted_note" colspan="7">
244 ${line.formatted_note| n}246 ${line.formatted_note| n}
245 </td>247 </td>
246 <tr>248 <tr>
@@ -329,7 +331,7 @@
329 <p class="std_text">${inv.comment | carriage_returns}</p>331 <p class="std_text">${inv.comment | carriage_returns}</p>
330 %endif332 %endif
331 %if inv.note2 :333 %if inv.note2 :
332 <p class="std_text">${inv.note2 | carriage_returns}</p>334 <p class="std_text">${inv.note2 | n}</p>
333 %endif335 %endif
334 <p style="page-break-after:always"></p>336 <p style="page-break-after:always"></p>
335 %endfor337 %endfor

Subscribers

People subscribed via source and target branches