Code review comment for lp:~nbdarvin/awn-extras/pidgin-adium

Revision history for this message
Mark Lee (malept) wrote :

> > > > I'd personally prefer that there's only one of these dock icon packs in
> > bzr
> > > > (as it seems to be fairly easy to get adium dock icons).
> > > no, adium icon themes use its own iconpack format with some features like
> > > custom animations and overlays, its described in plist for adium icon
> theme.
> > > there millions of adium themes at
> > > http://www.adiumxtras.com/index.php?a=search&cat_id=1
> >
> > What I was trying to say was I don't know why you're bundling 8 icon themes,
> > when you can download lots of them from the URL you quoted.
> some themes for example of use

You don't need *eight* examples though, right?

> >
> > > > The license for the icons needs to be documented somewhere.
> > > documented now
> >
> > Where, exactly? I didn't see it in a cursory look.
>
> http://bazaar.launchpad.net/~nbdarvin/awn-extras/pidgin-
> adium/annotate/head%3A/applets/maintained/pidgin-adium/adium-dock-
> themes/README.themes

The readme says that it's GPL-3, but <http://hg.adium.im/adium/file/d60e3dc89642/License.txt> says GPL-2 or later...

review: Needs Fixing

« Back to merge proposal