https://codereview.appspot.com/66230043/diff/1/upstart/service.go#newcode22
upstart/service.go:22: // MongoPath returns the executable path to be
used to run mongod on this machine.
// MongodPath ... (to match the func name). Also s/the executable//.
Actually, I'd prefer if you called this MongoDPath, so it matches the
SetMongoDPath from export_test.
LGTM with a few suggestions below.
https:/ /codereview. appspot. com/66230043/ diff/1/ provider/ local/prereqs. go local/prereqs. go (right):
File provider/
https:/ /codereview. appspot. com/66230043/ diff/1/ provider/ local/prereqs. go#newcode94 local/prereqs. go:94: " Juju requires version %v or greater.",
provider/
s/" Juju/"Juju/ - no need for the extra space in here where there's
another in the previous line.
https:/ /codereview. appspot. com/66230043/ diff/1/ provider/ local/prereqs. go#newcode113 local/prereqs. go:113: return version.Zero, errors. New("Couldn' t
provider/
parse version")
s/Couldn't parse version/Could not parse mongod version/ - slightly
better and clearer I think.
https:/ /codereview. appspot. com/66230043/ diff/1/ provider/ local/prereqs_ test.go local/prereqs_ test.go (right):
File provider/
https:/ /codereview. appspot. com/66230043/ diff/1/ provider/ local/prereqs_ test.go# newcode129 local/prereqs_ test.go: 129: c.Assert(err, gc.NotNil)
provider/
Check the actual error message?
https:/ /codereview. appspot. com/66230043/ diff/1/ upstart/ export_ test.go export_ test.go (right):
File upstart/
https:/ /codereview. appspot. com/66230043/ diff/1/ upstart/ export_ test.go# newcode3 export_ test.go: 3: package upstart
upstart/
Blank line before the package line. Also no need for 2013 in the
copyright.
https:/ /codereview. appspot. com/66230043/ diff/1/ upstart/ service. go
File upstart/service.go (right):
https:/ /codereview. appspot. com/66230043/ diff/1/ upstart/ service. go#newcode22 service. go:22: // MongoPath returns the executable path to be
upstart/
used to run mongod on this machine.
// MongodPath ... (to match the func name). Also s/the executable//.
Actually, I'd prefer if you called this MongoDPath, so it matches the
SetMongoDPath from export_test.
https:/ /codereview. appspot. com/66230043/ diff/1/ upstart/ upstart_ test.go upstart_ test.go (right):
File upstart/
https:/ /codereview. appspot. com/66230043/ diff/1/ upstart/ upstart_ test.go# newcode260 upstart_ test.go: 260: defer os.Remove(d)
upstart/
os.RemoveAll(d) instead?
https:/ /codereview. appspot. com/66230043/