juju-ci-tools

Code review comment for lp:~natefinch/juju-ci-tools/logrot

  1. logrot
  2. Merge into trunk
Revision history for this message
Aaron Bentley (abentley) wrote :

I think that you haven't run "make lint", because I see some lines longer than 79 characters. Please run "make lint" and fix any issues you find.

Please document all functions in assess_log_rotation.py

Please test parse_args.

See also inline comments.

review: Needs Fixing

« Back to merge proposal