Code review comment for lp:~natefinch/juju-ci-tools/logrot

Thanks.

Please don't add things to deploy_stack unless they are used by deploy_stack (i.e. deploy_job) itself. (The history is that deploy_stack was the first script, so some of its functionality has been reused in other scripts.)

Please don't add anything at all to jujuconfig. That is essentially an import from https://launchpad.net/juju-tools, and it would be best if they don't diverge.

I see that you have not addressed the inline comments about KeyError and tuple formattting. Please go back and make sure you've addressed all the inline comments.