Ubuntu One Control Panel

Code review comment for lp:~nataliabidart/ubuntuone-control-panel/update-file-sync-status

  1. update-file-sync-status
  2. Merge into trunk
Revision history for this message
Manuel de la Peña (mandel) wrote :

As with the other branch I get the following when running the tests:

E1101: 82:show_all_notifications_enabled: Instance of 'SyncDaemonTool' has no 'is_show_all_notifications_enabled' member
E1101: 87:enable_show_all_notifications: Instance of 'SyncDaemonTool' has no 'enable_show_all_notifications' member
E1101: 92:disable_show_all_notifications: Instance of 'SyncDaemonTool' has no 'enable_show_all_notifications' member
E1101: 97:get_root_dir: Instance of 'SyncDaemonTool' has no 'get_root_dir' member
E1101:102:get_shares_dir: Instance of 'SyncDaemonTool' has no 'get_shares_dir' member
E1101:107:get_shares_dir_link: Instance of 'SyncDaemonTool' has no 'get_shares_dir_link' member

when not running the ui tests. With the ui tests I get the following:

Must run 2nd check in another process.
===============================================================================
[ERROR]: ubuntuone.controlpanel.gui.qt.tests.test_gui.MainWindowTestCase.test_close_callback_can_be_none

Traceback (most recent call last):
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/tests/__init__.py", line 39, in inner
    result = test(instance)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/tests/__init__.py", line 80, in setUp
    self.ui = self.class_ui(**self.kwargs)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/gui.py", line 41, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/mainwindow_ui.py", line 32, in setupUi
    self.control_panel = ControlPanel(self.centralwidget)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/controlpanel.py", line 39, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/controlpanel_ui.py", line 68, in setupUi
    self.profile_tab = ProfilePanel()
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/profile.py", line 33, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/profile_ui.py", line 77, in setupUi
    self.retranslateUi(Form)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/profile_ui.py", line 91, in retranslateUi
    self.email_lineedit.setPlaceholderText(_('<email address hidden>'))
exceptions.AttributeError: 'QLineEdit' object has no attribute 'setPlaceholderText'
===============================================================================
[ERROR]: ubuntuone.controlpanel.gui.qt.tests.test_gui.MainWindowTestCase.test_close_event_calls_custom_close_callback

Traceback (most recent call last):
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/tests/__init__.py", line 39, in inner
    result = test(instance)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/tests/__init__.py", line 80, in setUp
    self.ui = self.class_ui(**self.kwargs)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/gui.py", line 41, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/mainwindow_ui.py", line 32, in setupUi
    self.control_panel = ControlPanel(self.centralwidget)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/controlpanel.py", line 39, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/controlpanel_ui.py", line 68, in setupUi
    self.profile_tab = ProfilePanel()
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/profile.py", line 33, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/profile_ui.py", line 77, in setupUi
    self.retranslateUi(Form)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/profile_ui.py", line 91, in retranslateUi
    self.email_lineedit.setPlaceholderText(_('<email address hidden>'))
exceptions.AttributeError: 'QLineEdit' object has no attribute 'setPlaceholderText'
===============================================================================
[ERROR]: ubuntuone.controlpanel.gui.qt.tests.test_gui.MainWindowTestCase.test_init_loads_ui

Traceback (most recent call last):
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/tests/__init__.py", line 39, in inner
    result = test(instance)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/tests/__init__.py", line 80, in setUp
    self.ui = self.class_ui(**self.kwargs)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/gui.py", line 41, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/mainwindow_ui.py", line 32, in setupUi
    self.control_panel = ControlPanel(self.centralwidget)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/controlpanel.py", line 39, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/controlpanel_ui.py", line 68, in setupUi
    self.profile_tab = ProfilePanel()
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/profile.py", line 33, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/profile_ui.py", line 77, in setupUi
    self.retranslateUi(Form)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/profile_ui.py", line 91, in retranslateUi
    self.email_lineedit.setPlaceholderText(_('<email address hidden>'))
exceptions.AttributeError: 'QLineEdit' object has no attribute 'setPlaceholderText'
===============================================================================
[ERROR]: ubuntuone.controlpanel.gui.qt.tests.test_controlpanel.ControlPanelTestCase.test_backend

Traceback (most recent call last):
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/tests/__init__.py", line 39, in inner
    result = test(instance)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/tests/__init__.py", line 80, in setUp
    self.ui = self.class_ui(**self.kwargs)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/controlpanel.py", line 39, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/controlpanel_ui.py", line 68, in setupUi
    self.profile_tab = ProfilePanel()
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/profile.py", line 33, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/profile_ui.py", line 77, in setupUi
    self.retranslateUi(Form)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/profile_ui.py", line 91, in retranslateUi
    self.email_lineedit.setPlaceholderText(_('<email address hidden>'))
exceptions.AttributeError: 'QLineEdit' object has no attribute 'setPlaceholderText'
===============================================================================
[ERROR]: ubuntuone.controlpanel.gui.qt.tests.test_controlpanel.ControlPanelTestCase.test_init_loads_ui

Traceback (most recent call last):
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/tests/__init__.py", line 39, in inner
    result = test(instance)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/tests/__init__.py", line 80, in setUp
    self.ui = self.class_ui(**self.kwargs)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/controlpanel.py", line 39, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/controlpanel_ui.py", line 68, in setupUi
    self.profile_tab = ProfilePanel()
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/profile.py", line 33, in __init__
    self.ui.setupUi(self)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/profile_ui.py", line 77, in setupUi
    self.retranslateUi(Form)
  File "/home/mandel/Projects/ubuntuone-control-panel/update-file-sync-status/ubuntuone/controlpanel/gui/qt/ui/profile_ui.py", line 91, in retranslateUi
    self.email_lineedit.setPlaceholderText(_('<email address hidden>'))
exceptions.AttributeError: 'QLineEdit' object has no attribute 'setPlaceholderText'

Tests when ran on Maverik.

review: Needs Fixing

« Back to merge proposal