Ubuntu One Control Panel

Code review comment for lp:~nataliabidart/ubuntuone-control-panel/ui-style-fixes

  1. ui-style-fixes
  2. Merge into trunk
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

> In line 70 of the diff:
>
> Instead of setting a fixed height of 30px, you should set the vertical
> sizePolicy to minimum, and the desired paddings.

Thanks for pointing this out. I agree with this, but the design spec states clearly that the height should be 30px: you can check this out in bug #824559 and in the spec file win_client_bottom_area.pdf inside the share Lisette made (under client/RTC/specs).

I also think that we should not have the font fixed to a given size... but not sure how to handle this with the design team.

« Back to merge proposal