Code review comment for lp:~nataliabidart/ubuntuone-control-panel/ui-style-fixes

In line 70 of the diff:

Instead of setting a fixed height of 30px, you should set the vertical sizePolicy to minimum, and the desired paddings.

While that may not result in a 30px tall frame, it will produce one with symmetrical padding, which is impossible to guarantee with fixed heights unless you fix the height of everything.

Fixing the height of everything is probably not practical because there are elements containing texts so the heights are dictated by the font sizes.

While we are using fixed point sizes (13px in most cases), that doesn't mean the texts themselves are 13px tall, because of descents.

Also, the use of fixed font sizes in px is probably an accessibility problem (it will not respect accessibility themes, like the ones with large fonts), and maybe should be discussed with design later on.