Merge lp:~nataliabidart/ubuntuone-control-panel/fix-lint into lp:ubuntuone-control-panel

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 253
Merged at revision: 253
Proposed branch: lp:~nataliabidart/ubuntuone-control-panel/fix-lint
Merge into: lp:ubuntuone-control-panel
Diff against target: 120 lines (+19/-12)
6 files modified
ubuntuone/controlpanel/dbus_service.py (+5/-10)
ubuntuone/controlpanel/gui/gtk/gui.py (+2/-0)
ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py (+4/-0)
ubuntuone/controlpanel/gui/gtk/widgets.py (+3/-0)
ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py (+2/-2)
ubuntuone/controlpanel/tests/test_sd_client.py (+3/-0)
To merge this branch: bzr merge lp:~nataliabidart/ubuntuone-control-panel/fix-lint
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+89777@code.launchpad.net

Commit message

- Fix lint issues (LP: #920640).

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntuone/controlpanel/dbus_service.py'
--- ubuntuone/controlpanel/dbus_service.py 2011-09-14 19:08:52 +0000
+++ ubuntuone/controlpanel/dbus_service.py 2012-01-23 20:19:25 +0000
@@ -1,9 +1,6 @@
1# -*- coding: utf-8 -*-1# -*- coding: utf-8 -*-
2
3# Authors: Alejandro J. Cura <alecu@canonical.com>
4# Authors: Natalia B. Bidart <nataliabidart@canonical.com>
5#2#
6# Copyright 2010 Canonical Ltd.3# Copyright 2010-2012 Canonical Ltd.
7#4#
8# This program is free software: you can redistribute it and/or modify it5# This program is free software: you can redistribute it and/or modify it
9# under the terms of the GNU General Public License version 3, as published6# under the terms of the GNU General Public License version 3, as published
@@ -23,14 +20,12 @@
23import sys20import sys
2421
25import dbus.service22import dbus.service
26# pylint: disable=E061123# pylint: disable=E0611,W0404
27# pylint: disable=W0404
28if 'gobject' in sys.modules:24if 'gobject' in sys.modules:
29 import gobject as GObject25 import gobject as GObject
30else:26else:
31 from gi.repository import GObject27 from gi.repository import GObject
32# pylint: enable=W040428# pylint: enable=E0611,W0404
33# pylint: enable=E0611
3429
35from dbus.mainloop.glib import DBusGMainLoop30from dbus.mainloop.glib import DBusGMainLoop
36from dbus.service import method, signal31from dbus.service import method, signal
@@ -156,6 +151,8 @@
156class ControlPanelBackend(dbus.service.Object):151class ControlPanelBackend(dbus.service.Object):
157 """Export the Control Panel backend thru DBus."""152 """Export the Control Panel backend thru DBus."""
158153
154 # pylint: disable=C0103,E1002
155
159 def __init__(self, backend, *args, **kwargs):156 def __init__(self, backend, *args, **kwargs):
160 """Create this instance of the backend."""157 """Create this instance of the backend."""
161 super(ControlPanelBackend, self).__init__(*args, **kwargs)158 super(ControlPanelBackend, self).__init__(*args, **kwargs)
@@ -164,8 +161,6 @@
164 logger.debug('ControlPanelBackend: created with %r, %r.',161 logger.debug('ControlPanelBackend: created with %r, %r.',
165 args, kwargs)162 args, kwargs)
166163
167 # pylint: disable=C0103
168
169 @log_call(logger.error)164 @log_call(logger.error)
170 @signal(dbus_interface=DBUS_PREFERENCES_IFACE, signature="a{ss}")165 @signal(dbus_interface=DBUS_PREFERENCES_IFACE, signature="a{ss}")
171 def UnauthorizedError(self, error):166 def UnauthorizedError(self, error):
172167
=== modified file 'ubuntuone/controlpanel/gui/gtk/gui.py'
--- ubuntuone/controlpanel/gui/gtk/gui.py 2011-09-19 18:13:28 +0000
+++ ubuntuone/controlpanel/gui/gtk/gui.py 2012-01-23 20:19:25 +0000
@@ -840,6 +840,8 @@
840 else:840 else:
841 self.on_success()841 self.on_success()
842842
843 # Class 'style' has no 'bg' member
844 # pylint: disable=E1101
843 odd_row_color = self.message.style.bg[gtk.STATE_NORMAL]845 odd_row_color = self.message.style.bg[gtk.STATE_NORMAL]
844 for i, device_info in enumerate(info):846 for i, device_info in enumerate(info):
845 device = Device(confirm_remove_dialog=self.confirm_remove_dialog)847 device = Device(confirm_remove_dialog=self.confirm_remove_dialog)
846848
=== modified file 'ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py'
--- ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py 2011-10-24 21:48:27 +0000
+++ ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py 2012-01-23 20:19:25 +0000
@@ -24,6 +24,10 @@
24from ubuntuone.controlpanel.gui.gtk import widgets24from ubuntuone.controlpanel.gui.gtk import widgets
2525
2626
27# Class 'style' has no 'fg' member
28# pylint: disable=E1101
29
30
27class LoadingTestCase(TestCase):31class LoadingTestCase(TestCase):
28 """Test suite for the Loading widget (a spinner plus a label)."""32 """Test suite for the Loading widget (a spinner plus a label)."""
2933
3034
=== modified file 'ubuntuone/controlpanel/gui/gtk/widgets.py'
--- ubuntuone/controlpanel/gui/gtk/widgets.py 2011-04-11 17:30:04 +0000
+++ ubuntuone/controlpanel/gui/gtk/widgets.py 2012-01-23 20:19:25 +0000
@@ -130,6 +130,9 @@
130 # Invalid name, Missing docstring, do not list fix-mes130 # Invalid name, Missing docstring, do not list fix-mes
131 # pylint: disable=C0103,C0111,W0511131 # pylint: disable=C0103,C0111,W0511
132132
133 # Class 'style' has no 'attach', 'set_background', 'paint_flat_box' member
134 # pylint: disable=E1101
135
133 __gsignals__ = {136 __gsignals__ = {
134 "damage_event": "override",137 "damage_event": "override",
135 }138 }
136139
=== modified file 'ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py'
--- ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py 2012-01-02 14:29:16 +0000
+++ ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py 2012-01-23 20:19:25 +0000
@@ -20,9 +20,9 @@
20import sys20import sys
2121
22if sys.platform == "win32":22if sys.platform == "win32":
23 import windows as platform23 from ubuntuone.controlpanel.gui.qt.uniqueapp import windows as platform
24else:24else:
25 import linux as platform25 from ubuntuone.controlpanel.gui.qt.uniqueapp import linux as platform
2626
27#pylint: disable=C010327#pylint: disable=C0103
28UniqueApplication = platform.UniqueApplication28UniqueApplication = platform.UniqueApplication
2929
=== modified file 'ubuntuone/controlpanel/tests/test_sd_client.py'
--- ubuntuone/controlpanel/tests/test_sd_client.py 2011-11-21 13:32:44 +0000
+++ ubuntuone/controlpanel/tests/test_sd_client.py 2012-01-23 20:19:25 +0000
@@ -34,6 +34,9 @@
34from ubuntuone.controlpanel import sd_client34from ubuntuone.controlpanel import sd_client
35from ubuntuone.controlpanel.tests import TestCase35from ubuntuone.controlpanel.tests import TestCase
3636
37# Instance of 'SyncDaemonTool' has no 'foo' member
38# pylint: disable=E1101
39
3740
38SAMPLE_LIMITS = {'upload': 999, 'download': 838}41SAMPLE_LIMITS = {'upload': 999, 'download': 838}
3942

Subscribers

People subscribed via source and target branches