Work fine with me to small remarks:
1. 'more the devices will be configurable.' - I guess is either 'more devices' or 'more of the devices'
2. I'm confused about this: 118 + show_notifs = bool_str(show_notifs) 119 + local_device["show_all_notifications"] = show_notifs
Why reassigning show_notifs and then storing it in the local_devices dict. What about just assigning it to the dict directly?
Since I don't consider the two above things to be lowering the quality of the code I approve and will trust the committer to the right thing.
« Back to merge proposal
Work fine with me to small remarks:
1. 'more the devices will be configurable.' - I guess is either 'more devices' or 'more of the devices'
2. I'm confused about this: show_notifs) "show_all_ notifications" ] = show_notifs
118 + show_notifs = bool_str(
119 + local_device[
Why reassigning show_notifs and then storing it in the local_devices dict. What about just assigning it to the dict directly?
Since I don't consider the two above things to be lowering the quality of the code I approve and will trust the committer to the right thing.