Code review comment for lp:~nataliabidart/ubuntuone-client/improve-error-handling

Revision history for this message
John Lenton (chipaca) wrote :

I like it.
I do have nits to pick:

* with the class called A:

    class A(object):
        """Do nothing."""
        pass

it isn't that it's hard to understand what the class does :) In this case, I think maybe the docstring should explain the intent a little more?

* a question: isn't using inlineCallbacks for a method that just calls one deferred-returning method, overkill?

* There's a pattern in the code that goes like

  kwargs = dict( ... a dict ... )
  yield self.foo(**kwargs)

without any real reason. That is a rather silly use of kwargs.

None of these are Need Fixings. On the whole, a lovely refactoring.

review: Approve

« Back to merge proposal