Code review comment for lp:~nataliabidart/ubuntuone-client/conflict-only-when-needed

Revision history for this message
Nicola Larosa (teknico) wrote :

Tests and lint checks pass, "assert_no_metadata" having no docstring notwithstanding. On the other hand, setUp and tearDown have docstrings, even though pylint does not care about them. :-)

I'm not sure about the "len_func = str.__len__" optimization. Isn't "len" a global name? What's the gain of this, has it been measured?

Overall, nice code, and welcomed tests. :-)

review: Approve

« Back to merge proposal