Code review comment for lp:~nataliabidart/ubuntuone-client/auth

The translation bits are wrong here. The correct way is already done in clientdefs.py.in. You should never set the textdomain on import of a module, like is done here. I would put most of the code in the credentials module into the script itself; as there is no reason for any other application to provide the service, or do most of what is being done in the credentials module.

The tests in ubuntuone-client are also under the toplevel tests/ directory. So your tests aren't being run by 'make test' here.

And if you intend for the SSO defines in clientdefs.py to be deprecated, I would suggest changing them to lambdas that emit a DeprecationWarning, and return the correctly imported values instead.