Merge lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.1 into lp:ubuntu-sso-client/stable-3-0

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 819
Merged at revision: 818
Proposed branch: lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.1
Merge into: lp:ubuntu-sso-client/stable-3-0
Diff against target: 41 lines (+3/-3)
2 files modified
ubuntu_sso/credentials.py (+2/-2)
ubuntu_sso/utils/webclient/libsoup.py (+1/-1)
To merge this branch: bzr merge lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.1
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+87378@code.launchpad.net

Commit message

[ Guillermo Gonzalez <email address hidden> ]
  - Remove _ping_url inlineCallbacks and make it return a deferred in order to
    make it work with twisted 11.1 (LP: #910163).
[ Rodney Dawes <email address hidden> ]
  - Disable a lint warning, to prevent builds failing on Lucid

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntu_sso/credentials.py'
--- ubuntu_sso/credentials.py 2011-08-22 16:21:36 +0000
+++ ubuntu_sso/credentials.py 2012-01-03 16:18:29 +0000
@@ -43,6 +43,7 @@
4343
44from functools import wraps44from functools import wraps
4545
46from twisted.internet import defer
46from twisted.internet.defer import inlineCallbacks, returnValue47from twisted.internet.defer import inlineCallbacks, returnValue
4748
48from ubuntu_sso import NO_OP, utils49from ubuntu_sso import NO_OP, utils
@@ -216,7 +217,6 @@
216 self.denial_cb(app_name)217 self.denial_cb(app_name)
217218
218 @handle_failures(msg='Problem opening the ping_url')219 @handle_failures(msg='Problem opening the ping_url')
219 @inlineCallbacks
220 def _ping_url(self, app_name, email, credentials):220 def _ping_url(self, app_name, email, credentials):
221 """Ping the self.ping_url with the email attached.221 """Ping the self.ping_url with the email attached.
222222
@@ -245,7 +245,7 @@
245 # but the returned deferred will never be fired (nataliabidart).245 # but the returned deferred will never be fired (nataliabidart).
246 response = urllib2.urlopen(request)246 response = urllib2.urlopen(request)
247 logger.debug('Url opened. Response: %s.', response.code)247 logger.debug('Url opened. Response: %s.', response.code)
248 returnValue(response)248 return defer.succeed(response)
249249
250 @handle_exceptions(msg='Problem opening the Ubuntu SSO user interface')250 @handle_exceptions(msg='Problem opening the Ubuntu SSO user interface')
251 def _show_ui(self, login_only):251 def _show_ui(self, login_only):
252252
=== modified file 'ubuntu_sso/utils/webclient/libsoup.py'
--- ubuntu_sso/utils/webclient/libsoup.py 2011-12-19 19:42:29 +0000
+++ ubuntu_sso/utils/webclient/libsoup.py 2012-01-03 16:18:29 +0000
@@ -33,7 +33,7 @@
33 def __init__(self, *args, **kwargs):33 def __init__(self, *args, **kwargs):
34 """Initialize this instance."""34 """Initialize this instance."""
35 super(WebClient, self).__init__(*args, **kwargs)35 super(WebClient, self).__init__(*args, **kwargs)
36 # pylint: disable=E061136 # pylint: disable=E0611,F0401
37 from gi.repository import Soup, SoupGNOME37 from gi.repository import Soup, SoupGNOME
38 self.soup = Soup38 self.soup = Soup
39 self.session = Soup.SessionAsync()39 self.session = Soup.SessionAsync()

Subscribers

People subscribed via source and target branches