Merge lp:~nataliabidart/ubuntu-sso-client/no-maximize into lp:ubuntu-sso-client

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 589
Merged at revision: 590
Proposed branch: lp:~nataliabidart/ubuntu-sso-client/no-maximize
Merge into: lp:ubuntu-sso-client
Diff against target: 26 lines (+5/-0)
2 files modified
data/ui.glade (+1/-0)
ubuntu_sso/tests/test_gui.py (+4/-0)
To merge this branch: bzr merge lp:~nataliabidart/ubuntu-sso-client/no-maximize
Reviewer Review Type Date Requested Status
Vincenzo Di Somma (community) Approve
Rodrigo Moya (community) Approve
Review via email: mp+33715@code.launchpad.net

Commit message

Main window can not be maximized (LP: #624101).

Description of the change

Main window can not be maximized.

To post a comment you must log in.
Revision history for this message
Rodrigo Moya (rodrigo-moya) :
review: Approve
Revision history for this message
Vincenzo Di Somma (vds) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/ui.glade'
--- data/ui.glade 2010-08-25 18:12:58 +0000
+++ data/ui.glade 2010-08-26 00:01:06 +0000
@@ -4,6 +4,7 @@
4 <!-- interface-naming-policy project-wide -->4 <!-- interface-naming-policy project-wide -->
5 <object class="GtkWindow" id="window">5 <object class="GtkWindow" id="window">
6 <property name="border_width">20</property>6 <property name="border_width">20</property>
7 <property name="resizable">False</property>
7 <property name="window_position">center</property>8 <property name="window_position">center</property>
8 <signal name="delete_event" handler="on_close_clicked"/>9 <signal name="delete_event" handler="on_close_clicked"/>
9 <child>10 <child>
1011
=== modified file 'ubuntu_sso/tests/test_gui.py'
--- ubuntu_sso/tests/test_gui.py 2010-08-25 18:12:58 +0000
+++ ubuntu_sso/tests/test_gui.py 2010-08-26 00:01:06 +0000
@@ -418,6 +418,10 @@
418 """The main window is shown at startup."""418 """The main window is shown at startup."""
419 self.assertTrue(self.ui.window.get_property('visible'))419 self.assertTrue(self.ui.window.get_property('visible'))
420420
421 def test_main_window_is_not_resizable(self):
422 """The main window can not be resized."""
423 self.assertFalse(self.ui.window.get_property('resizable'))
424
421 def test_closing_main_window_calls_close_callback(self):425 def test_closing_main_window_calls_close_callback(self):
422 """The close_callback is called when closing the main window."""426 """The close_callback is called when closing the main window."""
423 self.ui.close_callback = self._set_called427 self.ui.close_callback = self._set_called

Subscribers

People subscribed via source and target branches