Ubuntu Single Sign On Client

Code review comment for lp:~nataliabidart/ubuntu-sso-client/import-qt4reactor

  1. import-qt4reactor
  2. Merge into trunk
Revision history for this message
Manuel de la Peña (mandel) wrote :

Code works and tests pass. I'll give a +1 now but with the condition that we talk with <email address hidden> to ask why he added a conditional import of gobject in the code of txsecrets.

Is there a particular reason besides allowing to use Gtk3? Should we do the same in ubuntu-sso-login?

review: Approve

« Back to merge proposal