Code review comment for lp:~nataliabidart/magicicada-gui/main-window-iconifiable

Revision history for this message
Facundo Batista (facundo) wrote :

Massive errors, 31 times the following:

======================================================================
ERROR: SyncDaemon instance is shutdown at destroy time.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/internet/defer.py", line 117, in maybeDeferred
    result = f(*args, **kw)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/utils.py", line 191, in runWithWarningsSuppressed
    result = f(*a, **kw)
  File "/home/facundo/devel/reps/magicicada/review_logo-rainbow/magicicada/tests/test_magicicada.py", line 60, in tearDown
    self.ui.on_main_window_destroy(self.ui.main_window)
  File "/home/facundo/devel/reps/magicicada/review_logo-rainbow/magicicada/__init__.py", line 95, in on_main_window_destroy
    self.shutdown()
  File "/home/facundo/devel/reps/magicicada/review_logo-rainbow/magicicada/__init__.py", line 85, in shutdown
    reactor.stop() # instead of: gtk.main_quit()
  File "/usr/lib/python2.6/dist-packages/twisted/trial/unittest.py", line 854, in _
    return self._reactorMethods[name](*a, **kw)
  File "/usr/lib/python2.6/dist-packages/twisted/internet/base.py", line 552, in stop
    "Can't stop reactor that isn't running.")
ReactorNotRunning: Can't stop reactor that isn't running.

Most probably because a bad merge (was a criss cross one).

Please land the other branches, and merge this against trunk, and I'll check again.

Thanks!

review: Needs Fixing

« Back to merge proposal