Code review comment for lp:~nataliabidart/magicicada-gui/build-gui

Revision history for this message
Facundo Batista (facundo) wrote :

facundo@exepus:~/devel/reps/magicicada/review_build-gui$ nosetests

syncdaemon.py: Not installing glib2reactor because: reactor already installed.
..........................................EEE......
======================================================================
ERROR: Check that it polls mq until no more is needed.
----------------------------------------------------------------------
DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 0xac7ab6c [3.80157804489s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a8ac [3.79958200455s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a96c [3.80020308495s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7aa6c [3.80084300041s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7ae6c [3.80354785919s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7ac6c [3.80206394196s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7ad6c [3.80287098885s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7fb8c [3.81115484238s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7af6c [3.80402112007s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f08c [3.80454802513s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f18c [3.80509400368s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f28c [3.80576300621s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f38c [3.80635905266s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f48c [3.80693697929s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f58c [3.80750989914s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f68c [3.80805492401s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f78c [3.80859208107s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f88c [3.80918884277s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f98c [3.80973696709s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7fa8c [3.81028389931s] called=0 cancelled=0 SyncDaemon._check_mq()>

======================================================================
ERROR: Check that it polls mq while working in both.
----------------------------------------------------------------------
DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 0xac7a72c [4.99101114273s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f8ec [4.98898601532s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f24c [4.98936009407s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a86c [4.98973798752s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a7cc [4.99011516571s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a7ec [4.99048709869s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f4cc [4.99738693237s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7ad0c [4.99150681496s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7ac0c [4.99189996719s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a82c [4.99228000641s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7abac [4.99265503883s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7aaac [4.99302101135s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a6ac [4.99340105057s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7aeac [4.99377393723s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7ae0c [4.99414205551s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f2ec [4.9945371151s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f52c [4.99490809441s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f2cc [4.99528598785s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f62c [4.99590015411s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f32c [4.99657487869s] called=0 cancelled=0 SyncDaemon._check_mq()>
-------------------- >> begin captured logging << --------------------
dbus.connection: ERROR: Exception in handler for D-Bus signal:
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/dbus/connection.py", line 214, in maybe_handle_message
    self._handler(*args, **kwargs)
  File "/home/facundo/devel/reps/magicicada/review_build-gui/magicicada/syncdaemon.py", line 118, in _on_status_changed
    self._check_mq()
  File "/home/facundo/devel/reps/magicicada/review_build-gui/magicicada/syncdaemon.py", line 205, in _check_mq
    d.addCallback(self._process_mq)
AttributeError: 'NoneType' object has no attribute 'addCallback'
--------------------- >> end captured logging << ---------------------

======================================================================
ERROR: Check that it polls mq while working in metadata.
----------------------------------------------------------------------
DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 0xac7fb0c [4.98424005508s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7fd4c [4.98484396935s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7fc2c [4.98545002937s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7fd0c [4.98605298996s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f6ec [4.98667788506s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7fbcc [4.98729586601s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7fa2c [4.98790216446s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7fdac [4.98850893974s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f04c [4.98905682564s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7ff8c [4.98977208138s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7ffcc [4.99037408829s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a78c [4.99093484879s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7af0c [4.99149918556s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a9ec [4.99209499359s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a90c [4.99265098572s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7aaec [4.99318599701s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7acac [4.993735075s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7f3cc [4.99428009987s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac7a9cc [4.99480986595s] called=0 cancelled=0 SyncDaemon._check_mq()>
<DelayedCall 0xac8634c [4.99534797668s] called=0 cancelled=0 SyncDaemon._check_mq()>
-------------------- >> begin captured logging << --------------------
dbus.connection: ERROR: Exception in handler for D-Bus signal:
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/dbus/connection.py", line 214, in maybe_handle_message
    self._handler(*args, **kwargs)
  File "/home/facundo/devel/reps/magicicada/review_build-gui/magicicada/syncdaemon.py", line 118, in _on_status_changed
    self._check_mq()
  File "/home/facundo/devel/reps/magicicada/review_build-gui/magicicada/syncdaemon.py", line 205, in _check_mq
    d.addCallback(self._process_mq)
AttributeError: 'NoneType' object has no attribute 'addCallback'
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 51 tests in 2.864s

FAILED (errors=3)

review: Needs Fixing

« Back to merge proposal