plainbox-provider-phablet

Merge lp:~narahuang/plainbox-provider-phablet/propose into lp:plainbox-provider-phablet

  1. propose
  2. Merge into trunk
Proposed by Nara Huang
Status: Merged
Approved by: Daniel Manrique
Approved revision: 11
Merged at revision: 8
Proposed branch: lp:~narahuang/plainbox-provider-phablet/propose
Merge into: lp:plainbox-provider-phablet
Diff against target: 177 lines (+31/-8)
4 files modified
2013.com.canonical.certification:phablet/bin/adb_no_push (+1/-1)
2013.com.canonical.certification:phablet/bin/adb_test (+1/-1)
2013.com.canonical.certification:phablet/units/graphics.txt (+11/-5)
2013.com.canonical.certification:phablet/units/sensors.txt (+18/-1)
To merge this branch: bzr merge lp:~narahuang/plainbox-provider-phablet/propose
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+224642@code.launchpad.net

Description of the change

Add job requirements for sensors.txt, add summary for graphics.txt, and modify adb_test and adb_no_push.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

A tiny fix is needed :) for proximity, use require: capabilities.proximity-sensor.

review: Needs Fixing
lp:~narahuang/plainbox-provider-phablet/propose updated
11. By Nara Huang

Modify proximity sensor test

Revision history for this message
Nara Huang (narahuang) wrote :

The proximity sensor section is updated :D
Ready for review again!

Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks OK now, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '2013.com.canonical.certification:phablet/bin/adb_no_push'
--- 2013.com.canonical.certification:phablet/bin/adb_no_push 2014-06-25 13:36:50 +0000
+++ 2013.com.canonical.certification:phablet/bin/adb_no_push 2014-06-26 14:51:08 +0000
@@ -3,7 +3,7 @@
3test_path=$13test_path=$1
44
5if [ -z "$test_path" ]; then5if [ -z "$test_path" ]; then
6 echo Required binary $1 not found in PATH ($PATH)6 echo Required binary $1 not found in PATH $PATH
7 exit 17 exit 1
8fi8fi
99
1010
=== modified file '2013.com.canonical.certification:phablet/bin/adb_test'
--- 2013.com.canonical.certification:phablet/bin/adb_test 2014-06-25 13:36:50 +0000
+++ 2013.com.canonical.certification:phablet/bin/adb_test 2014-06-26 14:51:08 +0000
@@ -3,7 +3,7 @@
3test_path=$(which $1)3test_path=$(which $1)
44
5if [ -z "$test_path" ]; then5if [ -z "$test_path" ]; then
6 echo Required binary $1 not found in PATH ($PATH)6 echo Required binary $1 not found in PATH $PATH
7 exit 17 exit 1
8fi8fi
99
1010
=== modified file '2013.com.canonical.certification:phablet/units/graphics.txt'
--- 2013.com.canonical.certification:phablet/units/graphics.txt 2014-06-25 13:36:50 +0000
+++ 2013.com.canonical.certification:phablet/units/graphics.txt 2014-06-26 14:51:08 +0000
@@ -1,47 +1,52 @@
1id: graphics-0011id: graphics-001
2plugin: shell2plugin: shell
3flags: expected-failure3flags: expected-failure
4estimated_duration: 2
4command: adb_test check-egl-info5command: adb_test check-egl-info
6_summary: Check EGL info
5_description: 7_description:
6 Displays egl info from device, verifying that the egl drivers can be loaded.8 Displays egl info from device, verifying that the egl drivers can be loaded.
7 This test would fail if data/ and bin/ is not in $PATH.9 This test would fail if data/ and bin/ is not in $PATH.
8estimated_duration: 2
910
10id: graphics-00211id: graphics-002
11plugin: shell12plugin: shell
12flags: expected-failure13flags: expected-failure
13command: adb_test check-egl-compile14command: adb_test check-egl-compile
15estimated_duration: 2
16_summary: Verify compiling EGL program
14_description: 17_description:
15 Compiles a simple egl program, it will also display on screen.18 Compiles a simple egl program, it will also display on screen.
16 The objective is to verify that we can compile and link a basic egl19 The objective is to verify that we can compile and link a basic egl
17 program.20 program.
18 .21 .
19 TODO: this test can be flaky22 TODO: this test can be flaky
20estimated_duration: 2
2123
22id: graphics-00324id: graphics-003
23plugin: shell25plugin: shell
24command: adb_no_push test_egl_configs26command: adb_no_push test_egl_configs
27estimated_duration: 5
28_summary: Test EGL configs
25_description:29_description:
26 This test in itself should only fail if the other egl tests fail.30 This test in itself should only fail if the other egl tests fail.
27 It is more of use to verify and debug if there's a missing config31 It is more of use to verify and debug if there's a missing config
28 that mir would expect to run.32 that mir would expect to run.
29 This test would fail if data/ and bin/ is not in $PATH.33 This test would fail if data/ and bin/ is not in $PATH.
30estimated_duration: 5
3134
32id: graphics-00435id: graphics-004
33plugin: shell36plugin: shell
34command: adb_test mir_acceptance | ansi_parser37command: adb_test mir_acceptance | ansi_parser
38estimated_duration: 10
39_summary: Mir acceptance test
35_description: 40_description:
36 Runs the mir acceptance tests to verify that the platform will work with41 Runs the mir acceptance tests to verify that the platform will work with
37 mir.42 mir.
38 .43 .
39 NOTE this test can be flaky if run multiple times.44 NOTE this test can be flaky if run multiple times.
40 This test would fail if data/ and bin/ is not in $PATH.45 This test would fail if data/ and bin/ is not in $PATH.
41estimated_duration: 10
4246
43id: graphics-00547id: graphics-005
44plugin: manual48plugin: manual
49estimated_duration: 10
45_summary: Display brightness adjustment testing.50_summary: Display brightness adjustment testing.
46_description: 51_description:
47 PURPOSE:52 PURPOSE:
@@ -49,5 +54,6 @@
49 STEPS:54 STEPS:
50 1. Adjust display brightness in "Battery" of System Settings.55 1. Adjust display brightness in "Battery" of System Settings.
51 2. Verify that screen brightness could be adjusted.56 2. Verify that screen brightness could be adjusted.
52estimated_duration: 1057 VERIFICATION:
58 Could the screen brightness of test unit be adjusted?
5359
5460
=== modified file '2013.com.canonical.certification:phablet/units/sensors.txt'
--- 2013.com.canonical.certification:phablet/units/sensors.txt 2014-06-26 11:41:53 +0000
+++ 2013.com.canonical.certification:phablet/units/sensors.txt 2014-06-26 14:51:08 +0000
@@ -1,6 +1,8 @@
1id: sensors-0011id: sensors-001
2plugin: manual2plugin: manual
3estimated_duration: 203estimated_duration: 20
4requires:
5 capability.vibrate == 'supported'
4_summary: Verify the vibration of test unit works6_summary: Verify the vibration of test unit works
5_description:7_description:
6 PURPOSE:8 PURPOSE:
@@ -15,6 +17,8 @@
15id: sensors-00217id: sensors-002
16plugin: manual18plugin: manual
17estimated_duration: 2019estimated_duration: 20
20requires:
21 capability.vibrate == 'supported'
18_summary: Verify the pattern vibration of test unit works22_summary: Verify the pattern vibration of test unit works
19_description:23_description:
20 PURPOSE:24 PURPOSE:
@@ -29,6 +33,9 @@
29id: sensors-00333id: sensors-003
30plugin: manual34plugin: manual
31estimated_duration: 2035estimated_duration: 20
36requires:
37 capability.accelerometer == 'supported'
38 capability.vibrate == 'supported'
32_summary: Using accelerometer to detect test unit vibration39_summary: Using accelerometer to detect test unit vibration
33_description:40_description:
34 PURPOSE:41 PURPOSE:
@@ -58,6 +65,8 @@
58id: sensors-00565id: sensors-005
59plugin: manual66plugin: manual
60estimated_duration: 18067estimated_duration: 180
68requires:
69 capability.gps == 'supported'
61_summary: Check gps signal using test_gps70_summary: Check gps signal using test_gps
62_description:71_description:
63 PURPOSE: 72 PURPOSE:
@@ -73,6 +82,8 @@
73id: sensors-00782id: sensors-007
74plugin: manual83plugin: manual
75estimated_duration: 2084estimated_duration: 20
85requires:
86 capability.proximity-sensor == 'supported'
76_summary: Verify proximity sensor 87_summary: Verify proximity sensor
77_description:88_description:
78 PURPOSE:89 PURPOSE:
@@ -88,6 +99,8 @@
88id: sensors-00899id: sensors-008
89plugin: manual100plugin: manual
90estimated_duration: 10101estimated_duration: 10
102requires:
103 capability.light-sensor == 'supported'
91_summary: Verify light sensor104_summary: Verify light sensor
92_description:105_description:
93 PURPOSE:106 PURPOSE:
@@ -103,6 +116,8 @@
103id: sensors-011116id: sensors-011
104plugin: manual117plugin: manual
105estimated_duration: 10118estimated_duration: 10
119requires:
120 capability.gyroscope == 'supported'
106_summary: Verify orientation sensor121_summary: Verify orientation sensor
107_description:122_description:
108 PURPOSE:123 PURPOSE:
@@ -117,6 +132,9 @@
117132
118id: sensors-012133id: sensors-012
119plugin: manual134plugin: manual
135estimated_duration: 10
136requires:
137 capability.accelerometer == 'supported'
120_summary: Verify accelerometer get events when user shake the test device138_summary: Verify accelerometer get events when user shake the test device
121_description:139_description:
122 PURPOSE:140 PURPOSE:
@@ -128,5 +146,4 @@
128 4. Shake the test unit, check the acceleration sensor readings changing.146 4. Shake the test unit, check the acceleration sensor readings changing.
129 VERIFICATION:147 VERIFICATION:
130 Does the accelerometer get the readings from shaking?148 Does the accelerometer get the readings from shaking?
131estimated_duration: 10
132149

Subscribers

People subscribed via source and target branches