Code review comment for ~nansari/django-piston:fix-for-SN-1445

Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

I think I agree with Przemek here: piston's HttpResponseWrapper is apparently just trying to workaround an issue in django's HttpResponse, according to a comment in HttpResponseWrapper's code. But the issue http://code.djangoproject.com/ticket/9403 was fixed 11 years ago!!! :D:D:D

Maybe we can just drop HttpResponseWrapper and update piston's rc_factory.__getattr__() to return a plain HttpResponse? Afaict, the fix shipped in Django 1.4 (see https://github.com/django/django/commit/50255e3305 which is linked from the main issue). Based on piston's tox tests, we support Django >=1.4 which sounds like a really great coincidence and in which case we can just drop it and forget about django versions.

« Back to merge proposal