Merge lp:~nadiana/phatch/acceptance_test_pep8 into lp:phatch

Proposed by Nadia Alramli
Status: Merged
Merged at revision: not available
Proposed branch: lp:~nadiana/phatch/acceptance_test_pep8
Merge into: lp:phatch
Diff against target: 100 lines (+18/-11)
1 file modified
tests/run_acceptance_test.py (+18/-11)
To merge this branch: bzr merge lp:~nadiana/phatch/acceptance_test_pep8
Reviewer Review Type Date Requested Status
Stani Pending
Review via email: mp+20290@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nadia Alramli (nadiana) wrote :

Fixed pep8 errors

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/run_acceptance_test.py'
--- tests/run_acceptance_test.py 2010-02-27 12:59:47 +0000
+++ tests/run_acceptance_test.py 2010-02-28 02:00:33 +0000
@@ -30,6 +30,7 @@
3030
31report = logging.getLogger('report')31report = logging.getLogger('report')
3232
33
33def clean():34def clean():
34 """Clean generated files from previous run"""35 """Clean generated files from previous run"""
35 utils.remove_path(options.output)36 utils.remove_path(options.output)
@@ -38,6 +39,7 @@
38 utils.create_path(options.output)39 utils.create_path(options.output)
39 utils.create_path(config.OUT_ACTIONLISTS_PATH)40 utils.create_path(config.OUT_ACTIONLISTS_PATH)
4041
42
41def set_logger(log_path):43def set_logger(log_path):
42 """Setup logging"""44 """Setup logging"""
43 logging.basicConfig(45 logging.basicConfig(
@@ -55,6 +57,7 @@
55 report_handler = logging.FileHandler(options.report, mode='w')57 report_handler = logging.FileHandler(options.report, mode='w')
56 report.addHandler(report_handler)58 report.addHandler(report_handler)
5759
60
58if __name__ == '__main__':61if __name__ == '__main__':
59 # Option parser62 # Option parser
60 parser = optparse.OptionParser()63 parser = optparse.OptionParser()
@@ -136,8 +139,9 @@
136 )139 )
137 options, args = parser.parse_args()140 options, args = parser.parse_args()
138 if not options.no_execute and not os.path.exists(options.input):141 if not options.no_execute and not os.path.exists(options.input):
142 msg = 'The input directory "%s" is empty or doesn\'t exist'
139 logging.error(143 logging.error(
140 'The input directory "%s" is empty or doesn\'t exist' % options.input,144 msg % options.input,
141 )145 )
142 sys.exit(1)146 sys.exit(1)
143 choices_function = None147 choices_function = None
@@ -154,14 +158,12 @@
154 all_actions = [158 all_actions = [
155 action159 action
156 for name, action in phatchtools.get_actions().iteritems()160 for name, action in phatchtools.get_actions().iteritems()
157 if name not in config.DISABLE_ACTIONS161 if name not in config.DISABLE_ACTIONS]
158 ]
159 processing_actions = [162 processing_actions = [
160 action163 action
161 for name, action in phatchtools.get_actions().iteritems()164 for name, action in phatchtools.get_actions().iteritems()
162 if name not in config.DISABLE_ACTIONS165 if name not in config.DISABLE_ACTIONS
163 and name not in actions_by_tag['metadata']166 and name not in actions_by_tag['metadata']]
164 ]
165 metadata_actions = actions_by_tag['metadata'].values()167 metadata_actions = actions_by_tag['metadata'].values()
166 if options.tag == 'library':168 if options.tag == 'library':
167 phatchtools.generate_library_actionlists(options.output)169 phatchtools.generate_library_actionlists(options.output)
@@ -216,7 +218,9 @@
216 )218 )
217 choices_function = phatchtools.extended_choices219 choices_function = phatchtools.extended_choices
218 else:220 else:
219 actionlists = phatchtools.minimal_actionlists(all_actions, save_action)221 actionlists = phatchtools.minimal_actionlists(
222 all_actions, save_action,
223 )
220 phatchtools.generate_actionlists(224 phatchtools.generate_actionlists(
221 options.output,225 options.output,
222 actionlists,226 actionlists,
@@ -229,7 +233,9 @@
229 )233 )
230 phatchtools.generate_library_actionlists(options.output)234 phatchtools.generate_library_actionlists(options.output)
231 if not options.no_execute:235 if not options.no_execute:
232 errors = phatchtools.execute_actionlists(options.input, options=options.options)236 errors = phatchtools.execute_actionlists(
237 options.input, options=options.options,
238 )
233 if errors:239 if errors:
234 report.info('Number of errors: %s' % len(errors))240 report.info('Number of errors: %s' % len(errors))
235 report.info('Errors:\n\t%s' % '\n\t'.join(errors))241 report.info('Errors:\n\t%s' % '\n\t'.join(errors))
@@ -241,17 +247,18 @@
241 mismatch = []247 mismatch = []
242 output_files = [248 output_files = [
243 image249 image
244 for image in os.listdir(options.output)250 for image in os.listdir(options.output)]
245 ]
246 for image in output_files:251 for image in output_files:
247 path1 = os.path.join(options.compare, image)252 path1 = os.path.join(options.compare, image)
248 if os.path.exists(path1):253 if os.path.exists(path1):
249 path2 = os.path.join(options.output, image)254 path2 = os.path.join(options.output, image)
250 if not utils.compare(path1, path2):255 if not utils.compare(path1, path2):
251 result = utils.analyze(path1, path2)256 result = utils.analyze(path1, path2)
252 report.info('Mismatch: %s\nreason: %s' % (image, result['reason']))257 report.info(
258 'Mismatch: %s\nreason: %s' % (image, result['reason']))
253 if 'diff' in result:259 if 'diff' in result:
254 result['diff'].save(os.path.join(config.OUT_DIFF, image) + '.png')260 result['diff'].save(
261 os.path.join(config.OUT_DIFF, image) + '.png')
255 mismatch.append(image)262 mismatch.append(image)
256 else:263 else:
257 new.append(image)264 new.append(image)

Subscribers

People subscribed via source and target branches

to status/vote changes: