Ubuntu Developer Tools

Code review comment for lp:~nacc/ubuntu-dev-tools/update-vcs

  1. update-vcs
  2. Merge into trunk
Revision history for this message
Mattia Rizzolo (mapreri) wrote :

I think the current code is fine now.
@nacc do you plan to also write some tests? It would be really nice to have some.

I do not think things like the point 3 @bdrung should stop the merge (but you are welcome to implement it of course!).

Another thing: you are closing bug #1595744 in usd-importer with this, is that really fine?

review: Needs Information
Reply

« Back to merge proposal