~nacc/git-ubuntu:lp1741472-fix-dsc-orig-tarballs-native-packages-dsc-builder

Branch merges

Propose for merging

On hold for merging into git-ubuntu:master

git-ubuntu developers: Pending requested 2018-01-06

Diff: 269 lines (+120/-39)

4 files modified

gitubuntu/build.py (+41/-30)
gitubuntu/dsc.py (+36/-2)
gitubuntu/importer.py (+7/-7)
gitubuntu/test_dsc.py (+36/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

8fcbc20... by Nish Aravamudan on 2018-01-06

gitubuntu: add basic DSC tests

I started with tests for the bug I just fixed. I wanted to test
before/after conditions, but since the actual logic of the 'before' was
wrong (it returned None which was the API, but then the API was
incorrectly used), it felt more natural to just test the new API
specification.

5518ced... by Nish Aravamudan on 2018-01-05

build: orig tarballs do not exist for native source packages

Do not try to push orig tarballs if they do not exist. Found while
investigating LP #1741472.

481d6c3... by Nish Aravamudan on 2018-01-05

dsc: raise GitUbuntuDscTypeError for getting orig tarballs of native packages

The current Dsc class incorrectly handles native package orig tarballs
and returns None for the orig_tarball_path. It really needs to return
'nothing', as in an empty list (but the current API is a single return
value, not a list), or raise an Exception. I chose the latter.

Initially, I thought raising TypeError directly would be better, but it
obviously could be raised by other code, so I made a dummy subclass.

LP: #1741472

---

Note that I would like to use the dsc_builder code to test this, but
it's not yet merged.

3ebf6af... by Robie Basak on 2017-12-22

Initial test for import_unapplied_spi

Not got the verification at the end though.

a37f9ad... by Robie Basak on 2017-12-22

SourceSpec: default version is a string

2e2ef48... by Robie Basak on 2017-12-22

Create dsc branch on first use

Addresses LP: #1733895, but we still need to turn off separate dsc
branch creation.

00cb1fe... by Robie Basak on 2017-12-22

dsc -> source

Really dsc is the control file for a source rather than the source
itself, so isn't an accurate name for what this code does.

4637579... by Robie Basak on 2017-12-22

Factor out dsc_path_to_tree

3d0d41b... by Robie Basak on 2017-12-22

Add quilt patch supporot

f888274... by Robie Basak on 2017-12-21

dsc_builder: add non-native capability