~nacc/git-ubuntu:lp1708203-lint-do-not-clobber-working-tree

Branch merges

Propose for merging

Merged into git-ubuntu:master at revision bf0c2c109ff9b283e1c9781132e80e92752c7ed3

Server Team CI bot: Approve (continuous-integration) on 2017-09-18

Robie Basak: Pending requested 2017-09-18

Andreas Hasenack: Pending requested 2017-09-18

Diff: 126 lines (+42/-51)

2 files modified

gitubuntu/git_repository.py (+26/-0)
gitubuntu/lint.py (+16/-51)

api

Superseded for merging into git-ubuntu:master

Robie Basak: Approve on 2017-09-19

Server Team CI bot: Approve (continuous-integration) on 2017-09-15

Andreas Hasenack: Pending requested 2017-09-14

Diff: 126 lines (+42/-51)

2 files modified

gitubuntu/git_repository.py (+26/-0)
gitubuntu/lint.py (+16/-51)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

6455fd2... by Nish Aravamudan on 2017-09-18

git_repository: use a contextmanager for worktrees

This will be squasehd up

3ee33cd... by Nish Aravamudan on 2017-09-14

lint: do not clobber working tree

Rather than checking out to specific points and attempting to run
commands there, add a helper function in the repository that creates a
worktree to run a command in, and then runs it there. The worktree is
pruned upon return, regardless of the success or failure of the command.

LP: #1708203

2f61c42... by Nish Aravamudan on 2017-09-18

add tor to imported package list

Requested by Simon Deziel.

e5d3ac2... by Nish Aravamudan on 2017-09-14

build: fix syntax error when build fails

390621e... by Nish Aravamudan on 2017-09-13

lint: commitish_obj is only used to obtain commitish_id, drop it

e21ade1... by Nish Aravamudan on 2017-09-13

lint: use peel(Commit) rather than resolve().peel()

1acc00b... by Nish Aravamudan on 2017-09-13

lint: do not loop to find head branch name

Use the same pattern as added elsewhere.

5199842... by Nish Aravamudan on 2017-09-13

lint: properly handle default (no argument) cli case

Do not set a default value for commitish, as that leads to different behavior
(emits messages about detached HEAD) in main. Instead, let the default be None,
which results in us using HEAD in main, correctly.

be70e93... by Nish Aravamudan on 2017-09-12

lint: return to original head state if possible

Save off the branch we were at. This is still not the best solution,
but does leave us in the right place. The "correct" solution is to
clone the repo elsewhere and not modify the local repository at all.

LP: #1710035

a066105... by Nish Aravamudan on 2017-07-18

git ubuntu review: add new subcommand

Given a MP URL, this attempts to provide a local directory to use for
reviewing the MP (and allows one to auto-approve with lint results).

LP: #1702960