lint: separate check for reconstruct and deconstruct tag
I'm not sure why I wrote the code like this originally, but the intent
was to run every check (even if it doesn't necessarily make any sense to
have a deconstruct tag if there is no a reconstruct tag, in this case).
We will emit all failures as we go through the checks. Currently, we
only check deconstruct if reconstruct exists -- but then we use the
deconstruct tag variable to check against the logical tag. This will
obviously error if the reconstruct tag didn't exist originally.
We want to make sure that our gnupg binary and libraries are built
before git-ubuntu. In 48249b21607fdfbb80af9d53e8d0b1375d8778c1, the
local build reversion was reverted in turn, but the ordering was missed.
This leads to inconsistent builds.
This message was left behind to avoid a functional change in a previous
refactoring.
Unfortunately it has now become quite disconnected from the
implementation of logic that it is logging. It's at risk of becoming
wrong in the future if the implementation elsewhere is intentionally
changed.
Since it doesn't seem that important, drop it to avoid this happening.
git_repository: add close method and invoke it in a try/finally from importer
Push the ability to remove a repository's directory into the repository
itself and make caller's responsible for the removal.
Wrap importer.main in try/finally, where the finally clause calls
repo.close() directly. This removes our use of atexit, and ensures that
whether import succeeds or fails, the repository object we may have
created is cleaned up per the arguments.
These arguments all correspond to command line options that currently
use 'store_true', so the sensible default for all of them is False.
This does not change behaviour as all existing callers specify the
argument values explicitly, but it will be useful for the introduction
of tests in a future commit which isn't testing the behaviour of all of
these.
We had our own oauth part because launchpadlib needed a version that was
not present in pypi. Launchpadlib has since been bumped in the snap
(0c5eb5dcadbcf976f151d44cf2d26f302c5f3f2c "Bump and move vendored
launchpadlib Launchpad") and no longer requires oauth. We can therefore
drop the part source and reference in the yaml.
Further, our regex for the launchpadlib part's elision of oauth was too
broad and also elided oauthlib, which is used by lazr.restfulclient.
Since we want to use the oauth as needed by launchpadlib, drop this
elision altogether.
