~nacc/git-ubuntu:gu-review

Branch merges

Propose for merging

Merged into git-ubuntu:master at revision a066105299c91a3aae098ea601eb82ddbc5529ca

Server Team CI bot: Approve (continuous-integration) on 2017-09-13

Andreas Hasenack: Approve on 2017-09-13

Robie Basak: Pending requested 2017-09-12

Diff: 912 lines (+282/-77)

14 files modified

gitubuntu/__main__.py (+3/-1)
gitubuntu/build.py (+14/-7)
gitubuntu/buildsource.py (+1/-1)
gitubuntu/clone.py (+8/-5)
gitubuntu/importer.py (+34/-21)
gitubuntu/importlocal.py (+8/-6)
gitubuntu/importppa.py (+5/-3)
gitubuntu/lint.py (+7/-5)
gitubuntu/merge.py (+15/-11)
gitubuntu/queue.py (+4/-2)
gitubuntu/remote.py (+9/-3)
gitubuntu/review.py (+156/-0)
gitubuntu/submit.py (+12/-8)
gitubuntu/tag.py (+6/-4)

api

Superseded for merging into git-ubuntu:master

Andreas Hasenack: Needs Fixing on 2017-09-11

Server Team CI bot: Approve (continuous-integration) on 2017-09-09

Robie Basak: Pending requested 2017-09-08

Diff: 873 lines (+230/-348)

9 files modified

gitubuntu/__main__.py (+2/-0)
gitubuntu/clone.py (+0/-20)
gitubuntu/git_repository.py (+62/-36)
gitubuntu/importer.py (+0/-87)
gitubuntu/merge.py (+0/-149)
gitubuntu/remote.py (+0/-18)
gitubuntu/review.py (+140/-0)
gitubuntu/submit.py (+0/-23)
gitubuntu/versioning.py (+26/-15)

api

Superseded for merging into git-ubuntu:master

Server Team CI bot: Needs Fixing (continuous-integration) on 2017-09-08

Andreas Hasenack: Pending requested 2017-09-08

Robie Basak: Pending requested 2017-09-08

Diff: 447 lines (+252/-37)

5 files modified

gitubuntu/__main__.py (+43/-7)
gitubuntu/clone.py (+34/-7)
gitubuntu/lint.py (+22/-8)
gitubuntu/remote.py (+50/-15)
gitubuntu/review.py (+103/-0)

api

Superseded for merging into git-ubuntu:master

Server Team CI bot: Needs Fixing (continuous-integration) on 2017-09-06

Andreas Hasenack: Pending requested 2017-09-06

Robie Basak: Pending requested 2017-09-06

Diff: 453 lines (+247/-41)

5 files modified

gitubuntu/__main__.py (+38/-11)
gitubuntu/clone.py (+34/-7)
gitubuntu/lint.py (+22/-8)
gitubuntu/remote.py (+50/-15)
gitubuntu/review.py (+103/-0)

api

Superseded for merging into git-ubuntu:master

Robie Basak: Needs Fixing on 2017-07-28

Diff: 8362 lines (+4219/-3553)

15 files modified

gitubuntu/__main__.py (+142/-123)
gitubuntu/build.py (+132/-129)
gitubuntu/buildsource.py (+55/-59)
gitubuntu/clone.py (+109/-105)
gitubuntu/importer.py (+1388/-1176)
gitubuntu/importlocal.py (+312/-260)
gitubuntu/importppa.py (+256/-175)
gitubuntu/lint.py (+529/-506)
gitubuntu/merge.py (+423/-355)
gitubuntu/queue.py (+299/-281)
gitubuntu/remote.py (+120/-97)
gitubuntu/review.py (+117/-0)
gitubuntu/source_information.py (+15/-0)
gitubuntu/submit.py (+190/-174)
gitubuntu/tag.py (+132/-113)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

5c40be6... by Nish Aravamudan on 2017-09-13

review: drop unused sys

d1f6a0c... by Nish Aravamudan on 2017-09-13

review: return main from cli_main

1ff031b... by Nish Aravamudan on 2017-09-13

review: drop epilog from subparser

Will be squashed.

4ca0b55... by Nish Aravamudan on 2017-07-18

git ubuntu review: add new subcommand

Given a MP URL, this attempts to provide a local directory to use for
reviewing the MP (and allows one to auto-approve with lint results).

LP: #1702960

24e4372... by Nish Aravamudan on 2017-09-12

gitubuntu/*: refactor cli_main to return 0/1

Update __main__ to call sys.exit(args.func()), rather than using sys.exit.
This improves the modularity of the main() functions throughout.

f3a0bac... by Nish Aravamudan on 2017-09-12

import: refactor override_parents to raise ParentOverrideError

This helps put control flow logic only at the top-level.

257a5f6... by Nish Aravamudan on 2017-09-12

build: update check_repository to return a boolean

dce62ca... by Nish Aravamudan on 2017-09-12

versioning: add support for non-series information in the version string

libvirt uploads (SRUs) have versions like 1.2.2-0ubuntu13.1.23 which break
our parsing, which assumes anything between ubuntu_maj and ubuntu_min
is either a series or invalid. Extend our parsing to allow for an "other"
field, which is set when the substring between maj and min cannot be
parsed as a version.

LP: #1716737

4fd9289... by Nish Aravamudan on 2017-09-12

git_repository::fetch*: set GIT_TERMINAL_PROMPT=0 in env

When using http/https, LP will prompt for auth if a repository
is not found, because LP cannot distinguish between a private
repository (permission issue) and a non-existent repository until
the user is authenticated. This causes git itself to prompt
for authentication on the command-line, which we do not want. Since
we are only using http/https for fetch, disable the Git terminal
prompt via an environment variable. This does make clone and
review noisier, but that can be resolved in a future commit.

LP: #1716745

3debe45... by Nish Aravamudan on 2017-09-11

git_repository: use top-level-default for fetch_proto if not specified

This should not result in any functional change, but makes eventual
git-ubuntu review easier to implement.