Merge ~nacc/git-ubuntu:lp1735744-fix-lint-arguments into git-ubuntu:master

Proposed by Nish Aravamudan
Status: Merged
Merged at revision: 52a4b3ff6eeb322e922538403e73aec302a6fabf
Proposed branch: ~nacc/git-ubuntu:lp1735744-fix-lint-arguments
Merge into: git-ubuntu:master
Diff against target: 21 lines (+5/-5)
1 file modified
gitubuntu/lint.py (+5/-5)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Christian Ehrhardt  Approve
Review via email: mp+334658@code.launchpad.net

Description of the change

Make jenkins happy.

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Code change is small and looks reasonable.

Tested from the branch and now I can successfully add e.g. --target-branch=pkg/debian/sid and it works to check it.

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:52a4b3ff6eeb322e922538403e73aec302a6fabf
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/221/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Style Check
    SUCCESS: Unit Tests
    SUCCESS: Integration Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/221/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/gitubuntu/lint.py b/gitubuntu/lint.py
2index 498c254..a7428e5 100644
3--- a/gitubuntu/lint.py
4+++ b/gitubuntu/lint.py
5@@ -206,11 +206,11 @@ def parse_args(subparsers=None, base_subparsers=None):
6 def cli_main(args):
7 repo = gitubuntu.git_repository.GitUbuntuRepository(args.directory)
8 return do_lint(
9- repo,
10- args.commitish,
11- args.lint_namespace,
12- args.target_branch,
13- args.verbose,
14+ repo=repo,
15+ commitish=args.commitish,
16+ target_branch=args.target_branch,
17+ lint_namespace=args.lint_namespace,
18+ verbose=args.verbose,
19 )
20
21 def _check_commitish_exists(repo, commitish):

Subscribers

People subscribed via source and target branches