Code review comment for lp:~mzanetti/unity8/unified-stages

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> In
>
> """
> property bool hasDecoration: true
> """
>
> What about s/hasDecoration/decorated
> Would sound more like a QML property

in general, yes, I'd agree. Thing here is that there are 2, hasDecoration and showDecoration. toggling hasDecoration will resize the surface, while showDecoration will temporarily hide the decoration without actually resizing the surface. naming the property just "decorated" will blur the meaning between those too much IMO.

« Back to merge proposal